fix: testNamePattern matches against full name (fix #838) (#839)

vitest-dev · Feb 23, 2022 · e753493 · e753493
1 parent 4c9dbd0
commit e753493
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/docs/guide/index.md b/docs/guide/index.md
@@ -101,7 +101,7 @@ You can specify additional CLI options like `--port` or `--https`. For a full li
 | `-c, --config <path>` | Path to config file |
 | `-u, --update` | Update snapshots |
 | `-w, --watch` | Smart & instant watch mode |
-| `-t, --testNamePattern <pattern>` | Run tests with names matching the pattern |
+| `-t, --testNamePattern <pattern>` | Run tests with full names matching the pattern |
 | `--ui` | Enable UI |
 | `--open` | Open the UI automatically if enabled (default: `true`) |
 | `--api [api]` | Serve API, available options: `--api.port <port>`, `--api.host [host]` and `--api.strictPort` |

diff --git a/packages/vitest/src/node/cli.ts b/packages/vitest/src/node/cli.ts
@@ -11,7 +11,7 @@ cli
   .option('-c, --config <path>', 'path to config file')
   .option('-u, --update', 'update snapshot')
   .option('-w, --watch', 'watch mode')
-  .option('-t, --testNamePattern <pattern>', 'run test names with the specified pattern')
+  .option('-t, --testNamePattern <pattern>', 'run tests with full names matching the specified pattern')
   .option('--ui', 'enable UI')
   .option('--open', 'open UI automatically (default: !process.env.CI))')
   .option('--api [api]', 'serve API, available options: --api.port <port>, --api.host [host] and --api.strictPort')

diff --git a/packages/vitest/src/runtime/collect.ts b/packages/vitest/src/runtime/collect.ts
@@ -97,7 +97,7 @@ function interpretTaskModes(suite: Suite, namePattern?: string | RegExp, onlyMod
       }
     }
     if (t.type === 'test') {
-      if (namePattern && !t.name.match(namePattern))
+      if (namePattern && !getTaskFullName(t).match(namePattern))
         t.mode = 'skip'
     }
     else if (t.type === 'suite') {
@@ -115,6 +115,10 @@ function interpretTaskModes(suite: Suite, namePattern?: string | RegExp, onlyMod
   }
 }
 
+function getTaskFullName(task: TaskBase): string {
+  return `${task.suite ? `${getTaskFullName(task.suite)} ` : ''}${task.name}`
+}
+
 function someTasksAreOnly(suite: Suite): boolean {
   return suite.tasks.some(t => t.mode === 'only' || (t.type === 'suite' && someTasksAreOnly(t)))
 }