Skip to content

Commit

Permalink
feat!: remove --segfault-retry (#5514)
Browse files Browse the repository at this point in the history
  • Loading branch information
sheremet-va committed May 6, 2024
1 parent dbbbe43 commit ed60e40
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 161 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ concurrency:
cancel-in-progress: true

env:
VITEST_SEGFAULT_RETRY: 3
PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/.cache/ms-playwright
CYPRESS_CACHE_FOLDER: ${{ github.workspace }}/.cache/Cypress

Expand Down
1 change: 0 additions & 1 deletion packages/vitest/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const entries = {
'path': 'src/paths.ts',
'index': 'src/index.ts',
'cli': 'src/node/cli.ts',
'cli-wrapper': 'src/node/cli/cli-wrapper.ts',
'node': 'src/node.ts',
'suite': 'src/suite.ts',
'browser': 'src/browser.ts',
Expand Down
147 changes: 0 additions & 147 deletions packages/vitest/src/node/cli/cli-wrapper.ts

This file was deleted.

2 changes: 1 addition & 1 deletion packages/vitest/vitest.mjs
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/usr/bin/env node
import './dist/cli-wrapper.js'
import './dist/cli.js'
12 changes: 1 addition & 11 deletions test/config/test/exec-args.test.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,7 @@
import { afterAll, beforeAll, expect, test } from 'vitest'
import { expect, test } from 'vitest'
import { execa } from 'execa'
import { runVitest } from '../../test-utils'

// VITEST_SEGFAULT_RETRY messes with the node flags, as can be seen in packages/vitest/src/node/cli-wrapper.ts
// so here we remove it to make sure the tests are not affected by it
const ORIGIN_VITEST_SEGFAULT_RETRY = process.env.VITEST_SEGFAULT_RETRY
beforeAll(() => {
delete process.env.VITEST_SEGFAULT_RETRY
})
afterAll(() => {
process.env.VITEST_SEGFAULT_RETRY = ORIGIN_VITEST_SEGFAULT_RETRY
})

test.each([
{ pool: 'forks', execArgv: ['--hash-seed=1', '--random-seed=1', '--no-opt'] },
{ pool: 'threads', execArgv: ['--inspect-brk'] },
Expand Down

0 comments on commit ed60e40

Please sign in to comment.