types: wrong generic type params in type MockedClass

[Tanimodori]

Describe the bug

The primary part of MockedClass<T> is MockInstance<InstanceType<T>, ConstructorArgs<T>>

vitest/packages/vitest/src/integrations/spy.ts

Lines 101 to 106 in 34b06db

	export type MockedClass<T extends Constructable> = MockInstance<
	InstanceType<T>,
	T extends new (...args: infer P) => any ? P : never
	> & {
	prototype: T extends { prototype: any } ? Mocked<T['prototype']> : never
	} & T

But I think MockInstance<A, R> which is primarily SpyInstance<TArgs, TReturns> is a kind of mock new (...Targs)=>TReturns, should MockedClass<T> be MockInstance<ConstructorArgs<T>, InstanceType<T>> instead of MockInstance<InstanceType<T>, ConstructorArgs<T>>?

vitest/packages/vitest/src/integrations/spy.ts

Lines 39 to 56 in 34b06db

	export interface SpyInstance<TArgs extends any[] = any[], TReturns = any> {
	getMockName(): string
	mockName(n: string): this
	mock: MockContext<TArgs, TReturns>
	mockClear(): this
	mockReset(): this
	mockRestore(): void
	getMockImplementation(): ((...args: TArgs) => TReturns) | undefined
	mockImplementation(fn: ((...args: TArgs) => TReturns) | (() => Promise<TReturns>)): this
	mockImplementationOnce(fn: ((...args: TArgs) => TReturns) | (() => Promise<TReturns>)): this
	mockReturnThis(): this
	mockReturnValue(obj: TReturns): this
	mockReturnValueOnce(obj: TReturns): this
	mockResolvedValue(obj: Awaited<TReturns>): this
	mockResolvedValueOnce(obj: Awaited<TReturns>): this
	mockRejectedValue(obj: any): this
	mockRejectedValueOnce(obj: any): this
	}

vitest/packages/vitest/src/integrations/spy.ts

Line 58 in 34b06db

export interface MockInstance<A extends any[] = any[], R = any> extends SpyInstance<A, R> {}

Reproduction

n/a

System Info

n/a

Used Package Manager

npm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sheremet-va]

Yes, I think you are right. PR welcome.