Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight sub_threshold items in coverage html #3253

Closed
4 tasks done
herzaso opened this issue Apr 25, 2023 · 3 comments · Fixed by #3254
Closed
4 tasks done

Highlight sub_threshold items in coverage html #3253

herzaso opened this issue Apr 25, 2023 · 3 comments · Fixed by #3254

Comments

@herzaso
Copy link

herzaso commented Apr 25, 2023

Clear and concise description of the problem

When generating an html coverage, there is no way to distinct items that are above the threshold from those that are below and needs to be fixed.

Suggested solution

I suggest marking the errors in the table in red or something that will pop up

Alternative

No response

Additional context

No response

Validations

@AriPerkkio
Copy link
Member

@AriPerkkio
Copy link
Member

Looks like c8 supports it also but hasn't documented it. You can also pass these to c8 provider.

Here is example of how the table can look like with configuration below:

export default defineConfig({
  test: {
    coverage: {
      watermarks: {
        functions: [90, 95],
        branches: [90, 95],
        lines: [90, 95],
        statements: [90, 95],
      },

image

@herzaso
Copy link
Author

herzaso commented Apr 25, 2023

Works great! thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants