Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce server option to pass down options for Vite Node instead of deps.inline/deps.exclude #3522

Closed
4 tasks done
sheremet-va opened this issue Jun 5, 2023 · 2 comments · Fixed by #3725
Closed
4 tasks done
Labels
enhancement New feature or request pr welcome
Milestone

Comments

@sheremet-va
Copy link
Member

sheremet-va commented Jun 5, 2023

Clear and concise description of the problem

Currently, all options to Vite Node are passed down through different options. If someone uses Vite Node as their primary runtime, it is easier to pass down its options via a single entry. To close #3521, we also need a separate option that can be used for Vite Node initialization for those who use Vite Node as their primary runtime tool.

Suggested solution

Add a server option to Vitest config that is equal to ViteNodeServerOptions:

export interface ViteNodeServerOptions {

Alternative

No response

Additional context

No response

Validations

@sheremet-va sheremet-va added enhancement New feature or request pr welcome labels Jun 5, 2023
@sheremet-va sheremet-va changed the title Introduce server option to pass down options for Vite Node Introduce server option to pass down options for Vite Node instead of deps.inline/deps.exclude Jun 6, 2023
@fenghan34
Copy link
Contributor

Hi @ sheremet-va, I would like to know if I can try to create a PR for this. 😀

@sheremet-va
Copy link
Member Author

Hi @ sheremet-va, I would like to know if I can try to create a PR for this. 😀

Sure

@sheremet-va sheremet-va added this to the 0.33.0 milestone Jul 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request pr welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants