Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples with enabled deps.optimizer #3523

Closed
4 tasks done
sheremet-va opened this issue Jun 5, 2023 · 2 comments · Fixed by #3854
Closed
4 tasks done

Add more examples with enabled deps.optimizer #3523

sheremet-va opened this issue Jun 5, 2023 · 2 comments · Fixed by #3854
Labels
documentation Improvements or additions to documentation pr welcome

Comments

@sheremet-va
Copy link
Member

sheremet-va commented Jun 5, 2023

Clear and concise description of the problem

Since deps.inline is deprecated (#3521), we should change our existing examples that rely on it like Solid.js to use optimizer instead.

Suggested solution

Enable deps.optimizer in JSDOM/happy-dom examples. Since Node.js tests don't usually benefit from it, we can ignore them if they already don't rely on deps.inline.

We should also add examples where optimizer helps with alias incompatibility like preact (#3502).

This PR should also remove experimental status from deps.experimentalOptimizer.

Alternative

No response

Additional context

No response

Validations

@sheremet-va sheremet-va added documentation Improvements or additions to documentation pr welcome labels Jun 5, 2023
@eryue0220
Copy link
Contributor

Can I pick it up?

@sheremet-va
Copy link
Member Author

Can I pick it up?

Sure

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation pr welcome
Projects
None yet
2 participants