🐛 Bug: Hidden breaking changes from 0.33 -> 0.34

[hinogi]

Describe the bug

Usage of files outside the projectfolder worked in 0.33 like require('path').resolve(somerootdir, 'somepath.ts') in setupFiles from a shared config for example. in 0.34 you may need to add { server: { fs: { strict: false }}} might be a result of updating defineConfig from vite?

Changing process.env.NODE_ENV for example did work in 0.33. In 0.34 you get an error that you cannot change rvalues.

Reproduction

https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/basic?initialPath=__vitest__/

System Info

vitest 0.34

Used Package Manager

npm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• github (Open reproduction)

[sheremet-va]

These are not breaking changes, but bugs.

[abrowne2]

Experiencing issues with setupFiles between 0.33 -> 0.34

I cannot share further debug details because they are proprietary, but this .on issue is quite strange and does not happen in 0.33.

Test config;

  test: {
    includeSource: ['src/lib/**/*.ts', 'src/lib/**/*.js', 'src/lib/**/*.svelte', 'src/tests/*.test.ts'],
    setupFiles: [
      'src/tests/globalTestSetup.ts'
    ],
    hookTimeout: 25000
  },

My beforeAll function applies some global shared variables throughout all of my tests and calls a playwright page setup context function; there's no indication that's having issues in the new version (struggling here):

beforeAll(async () => {
    if (globalThis.processInProgress && !globalThis.context) {
        await waitUntilReady();
    }

    // ... omitted for brevity ...
});

[sheremet-va]

Experiencing issues with setupFiles between 0.33 -> 0.34

This just looks like a version mismatch. Check that all @vitest/ packages use the same version in you lockfile.