Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vitest/coverage-v8 has an improper peer dependency in 1.0.0-beta.2 #4374

Closed
6 tasks done
mpodwysocki opened this issue Oct 25, 2023 · 3 comments
Closed
6 tasks done

Comments

@mpodwysocki
Copy link

mpodwysocki commented Oct 25, 2023

Describe the bug

Currently published @vitest/coverage-v8 has an improper peer dependency and will fail to install with vitest 1.0.0-beta.2.

The package.json currently published is the following with the npm code view

  "peerDependencies": {
    "vitest": ">=0.32.0 <1"
  },

This causes pnpm to fail to install.

Reproduction

Updating using pnpm where we do not allow strict peer dependencies to fail.

System Info

System:
    OS: macOS 14.0
    CPU: (8) arm64 Apple M2
    Memory: 189.48 MB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.0.0 - ~/.nvm/versions/node/v21.0.0/bin/node
    npm: 10.2.0 - ~/.nvm/versions/node/v21.0.0/bin/npm
    pnpm: 8.9.2 - /opt/homebrew/bin/pnpm
  Browsers:
    Brave Browser: 118.1.59.122
    Chrome: 118.0.5993.117
    Safari: 17.0
    Safari Technology Preview: 17.4

Used Package Manager

pnpm

Validations

@AriPerkkio
Copy link
Member

Fixed by #4299.

@mpodwysocki
Copy link
Author

@AriPerkkio When do we expect the fix to be published?

@AriPerkkio
Copy link
Member

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants