Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser and typecheck do not work together #5067

Closed
arv opened this issue Jan 29, 2024 · 2 comments · Fixed by #5080
Closed

browser and typecheck do not work together #5067

arv opened this issue Jan 29, 2024 · 2 comments · Fixed by #5080

Comments

@arv
Copy link

arv commented Jan 29, 2024

Describe the bug

I want to run both browser and typecheck tests at the same time.

When typecheck is enable the typecheck tests gets included and run in the browser.

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-rac6tk?file=test%2Ftypes.test-d.ts

System Info

Local:


  System:
    OS: macOS 14.3
    CPU: (8) arm64 Apple M1
    Memory: 1.06 GB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.volta/tools/image/node/18.18.2/bin/node
    Yarn: 1.22.19 - ~/.volta/tools/image/yarn/1.22.19/bin/yarn
    npm: 9.8.1 - ~/.volta/tools/image/node/18.18.2/bin/npm
    pnpm: 8.9.2 - ~/Library/pnpm/pnpm
    bun: 1.0.7 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: 109.1.47.171
    Chrome: 120.0.6099.234
    Safari: 17.3
  npmPackages:
    @vitest/browser: ^1.2.1 => 1.2.1
    vitest: ^1.2.1 => 1.2.1


### Used Package Manager

npm

### Validations

- [X] Follow our [Code of Conduct](https://github.com/vitest-dev/vitest/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/vitest-dev/vitest/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://vitest.dev/guide/).
- [X] Check that there isn't [already an issue](https://github.com/vitest-dev/vitest/issues) that reports the same bug to avoid creating a duplicate.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitest-dev/vitest/discussions) or join our [Discord Chat Server](https://chat.vitest.dev).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.
@sheremet-va
Copy link
Member

I think this is the same as #5019

@sheremet-va sheremet-va closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
@sheremet-va sheremet-va reopened this Jan 30, 2024
@sheremet-va
Copy link
Member

Ok, I see now. It is the same reason, but it can be fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants