Stack overflow caused by large output #5614

RobinClowers · 2024-04-24T18:01:24Z

Describe the bug

This appears to be a regression of #3060. When an error occurs with a very large output (in my case from @testing-library/react), picocolors causes a stack overflow.

⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯
RangeError: Maximum call stack size exceeded
 ❯ replaceClose node_modules/picocolors/picocolors.js:22:21
 ❯ replaceClose node_modules/picocolors/picocolors.js:25:30
 ❯ replaceClose node_modules/picocolors/picocolors.js:25:30
 ❯ replaceClose node_modules/picocolors/picocolors.js:25:30
 ❯ replaceClose node_modules/picocolors/picocolors.js:25:30
 ❯ replaceClose node_modules/picocolors/picocolors.js:25:30
 ❯ replaceClose node_modules/picocolors/picocolors.js:25:30
 ❯ replaceClose node_modules/picocolors/picocolors.js:25:30
 ❯ replaceClose node_modules/picocolors/picocolors.js:25:30

Reproduction

Unfortunately I don't have a reproduction handy. I suspect this would reproduce with RTL, a large dom and DEBUG_PRINT_LIMIT=100000 vitest.

System Info

System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 5.56 GB / 64.00 GB
    Shell: 5.2.15 - /opt/homebrew/bin/bash
  Binaries:
    Node: 18.18.0 - ~/.volta/tools/image/node/18.18.0/bin/node
    Yarn: 1.22.17 - ~/.volta/tools/image/yarn/1.22.17/bin/yarn
    npm: 9.8.1 - ~/.volta/tools/image/node/18.18.0/bin/npm
  Browsers:
    Brave Browser: 121.1.62.156
    Chrome: 124.0.6367.62
    Chrome Canary: 121.0.6125.0
    Edge: 124.0.2478.51
    Firefox: 125.0.1
    Safari: 17.4.1
  npmPackages:
    vitest: ^1.5.0 => 1.5.0

Used Package Manager

yarn

Validations

Follow our Code of Conduct
Read the Contributing Guidelines.
Read the docs.
Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
The provided reproduction is a minimal reproducible example of the bug.

The text was updated successfully, but these errors were encountered:

hi-ogawa · 2024-04-25T02:43:36Z

The linked issue #3060 seems related, but I'm not sure how to get the error considering the fix #3078 seems okay.

I tried something like this and still seems fine with DEBUG_PRINT_LIMIT=100000:

    const node = <div id="hey">
      {[...Array(5000)].map(i => <div key={i} id={i} style={{ color: "red" }}><span/></div>)}
    </div>
    render(node);
    screen.getByRole('no-such-thing') // testing-library throws an error

TestingLibraryElementError: Unable to find an accessible element with the role "no-such-thing"

There are no accessible roles. But there might be some inaccessible roles. If you wish to access them, then set the `hidden` option to `true`. Learn more about this here: https://testing-library.com/docs/dom-testing-library/api-queries#byrole

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      id="hey"
    >

github-actions · 2024-04-25T02:43:58Z

Hello @RobinClowers. Please provide a minimal reproduction using a GitHub repository or StackBlitz (you can also use examples). Issues marked with needs reproduction will be closed if they have no activity within 3 days.

RobinClowers · 2024-05-09T23:30:50Z

Can I get this issue reopened? I've created a reproduction. Just yarn && yarn test should reproduce the bug (npm should work fine too). They key thing turns out to be CI=1, it seems like there is some code path that's only happening in CI that also needs the guard.

Let me know if I should open a new issue instead of reopening this one.

hi-ogawa · 2024-05-10T00:00:43Z

Confirmed the issue. Thanks for the reproduction 👍

hi-ogawa · 2024-05-10T03:13:03Z

It seems like call stack error is due to a specific implementation of picocolors and technically it can be avoided, so I raised an issue upstream alexeyraspopov/picocolors#63.

As upstream might not progress fast, Vitest can still fix this by patching picocolors or simply truncate the error message wherever this is happening.

Also the minimum repro is this:
https://stackblitz.com/edit/vitest-dev-vitest-858psz?file=test%2Frepro.test.ts

// CI=1 npm run test

import { test } from "vitest";

test("repro", () => {
  const x = "\x1b[34m" + "x" + "\x1b[39m"
  throw new Error(x.repeat(10000));
})

alexeyraspopov · 2024-05-14T02:52:43Z

The upstream issue is fixed and thanks @hi-ogawa for contribution. picocolors@1.0.1 is published and now should be more resilient to large colored outputs.

RobinClowers · 2024-05-15T23:15:41Z

@hi-ogawa are you planning to bump the version in vitest? I'm happy to submit that PR if that's helpful.

hi-ogawa · 2024-05-16T00:48:38Z

@RobinClowers picocolors is not bundled with vitest package, so you should be able to update the transitive dependency on your own. Depending on package manager, for example, pnpm dedupe would help.

I also confirmed the last reproduction is fixed with package.json overrdies
https://stackblitz.com/edit/vitest-dev-vitest-a3p1xh?file=package.json

Also picocolors bump is included in the next Renovate PR #5712, so it should come soon with the next release.

RobinClowers · 2024-05-16T02:46:22Z

Yeah, I already updated my app, just wanted to make sure it would land here, sounds like the renovate PR has it covered!

hi-ogawa · 2024-05-16T02:53:22Z

Cool, thanks for the reminder! As you confirmed it's working for you, I'll close this issue then.

I just remembered that Vitest has utilities which is mostly a copy of picocolors internally, so I'm updating that in a separate PR #5733.

RobinClowers added the pending triage label Apr 24, 2024

hi-ogawa added the needs reproduction label Apr 25, 2024

github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024

hi-ogawa reopened this May 9, 2024

hi-ogawa added p3-minor-bug An edge case that only affects very specific usage (priority) and removed needs reproduction pending triage labels May 9, 2024

hi-ogawa mentioned this issue May 10, 2024

RangeError: Maximum call stack size exceeded when coloring already colored long string alexeyraspopov/picocolors#63

Closed

hi-ogawa mentioned this issue May 16, 2024

fix(utils): fix color util maximum call stack error #5733

Merged

6 tasks

hi-ogawa closed this as completed May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stack overflow caused by large output #5614

Stack overflow caused by large output #5614

RobinClowers commented Apr 24, 2024

hi-ogawa commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

RobinClowers commented May 9, 2024

hi-ogawa commented May 10, 2024

hi-ogawa commented May 10, 2024 •

edited

alexeyraspopov commented May 14, 2024

RobinClowers commented May 15, 2024

hi-ogawa commented May 16, 2024 •

edited

RobinClowers commented May 16, 2024

hi-ogawa commented May 16, 2024

Stack overflow caused by large output #5614

Stack overflow caused by large output #5614

Comments

RobinClowers commented Apr 24, 2024

Describe the bug

Reproduction

System Info

Used Package Manager

Validations

hi-ogawa commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

RobinClowers commented May 9, 2024

hi-ogawa commented May 10, 2024

hi-ogawa commented May 10, 2024 • edited

alexeyraspopov commented May 14, 2024

RobinClowers commented May 15, 2024

hi-ogawa commented May 16, 2024 • edited

RobinClowers commented May 16, 2024

hi-ogawa commented May 16, 2024

hi-ogawa commented May 10, 2024 •

edited

hi-ogawa commented May 16, 2024 •

edited