Tests start failing when upgrading from 1.5.2 to 1.5.3

[osmestad]

Describe the bug

For our code base a lot of tests start failing when upgrading from 1.5.2 to 1.5.3 or 1.6.0. It seems to relate to deep object comparison where we use Immutable.js. I'm guessing, but maybe related to this change: #5621?

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-qtcox7?file=test%2Fim.test.ts

System Info

Any? at least on Macs and Linux and Stackblitz :-)

Used Package Manager

yarn

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[hi-ogawa]

I checked the repro and they have different _tail.ownerID, so that's now caught by #5621.

Just tried a simpler repro and I got this
https://stackblitz.com/edit/vitest-dev-vitest-tybjr1?file=test%2Fim.test.ts

import { expect, test } from 'vitest';
import * as im from 'immutable';

test('repro', () => {
  const x = im.List([{ x: 1 }]);
  const y = im.List([1]).map(i => ({ x: i }));
  console.log("[x._tail]", x._tail); // [x._tail] VNode { array: [ { x: 1 } ], ownerID: undefined }
  console.log("[y._tail]", y._tail); // [y._tail] VNode { array: [ { x: 1 } ], ownerID: OwnerID {} }
  expect(x).toEqual(y);
});

Since message says "Compared values have no visual difference.", probably we need to do something special for immutable js for iterator checks too. Perhaps we can check how Jest is dealing with this.

EDIT: Just confirmed the same test doesn't fail on Jest https://github.com/hi-ogawa/reproductions/tree/main/jest-immutable

[osmestad]

Thanks for the quick fix!