Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude/include config handling and missing workspacePath #192

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: exclude/include config handling and missing workspacePath #192

merged 1 commit into from
Nov 14, 2023

Conversation

mash-graz
Copy link
Contributor

@mash-graz mash-graz commented Oct 28, 2023

This PR fixes two issues related to test file inclusion/exclusion:

  1. in getCombinedConfig() the deprecated vscode settings or better its default values, when not found, always overruled the settings in the vite and vitest configs. By this change the entries in both configuration variants get merged.

Fixes Bugs in: #187

  1. The fix in discover.ts just adds an obviously missing variable, which caused an error

Pasted image

@PindaPixel
Copy link

What is required to get this merged?

@mash-graz
Copy link
Contributor Author

What is required to get this merged?

I'm also somehow surprised, that it seems to be completely ignored by the maintainers (@zxch3n) and developers of the patched code (@huwshimi).

@zxch3n zxch3n merged commit bee4f6e into vitest-dev:main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants