Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File path corrections for Windows #24

Merged
merged 8 commits into from
Apr 27, 2022
Merged

File path corrections for Windows #24

merged 8 commits into from
Apr 27, 2022

Conversation

xon52
Copy link
Contributor

@xon52 xon52 commented Apr 24, 2022

I have not found that the latest updates have helped, but I did find that the path issues identified by @AlmarAubel are the issue. These changes make a single path sanitization function which has solved the issues for runTest() (normal) on my Windows 10 machine.

I have still been unable to run/fix the debugTest() (debug) for my windows machine

@AlmarAubel
Copy link
Contributor

AlmarAubel commented Apr 24, 2022

It looks almost the same as me first try to fix this issue (see this commit), although you made some nice additional refactoring ;). But this was not working for every one.

However your fix is working on my windows computer. But I'm not sure if some functions will be broken if you don't pass the env vars to the spawn command.

@xon52
Copy link
Contributor Author

xon52 commented Apr 25, 2022

@AlmarAubel I'll take it out the changes to spawn() when I update with the debug updates; I didn't mean to leave them in. 👍

  • I do need to remove the 'powershell' for shell though. It's now: shell: isWindows which is the least change I could make to get it to work.

Might make another PR for it though as I cannot see what they do. Not sure where it comes from or why it's needed. Seems to work on Mac and Windows and may be leftover boiler plate or a mask for a solved issue 🤷‍♂️

@xon52 xon52 marked this pull request as ready for review April 25, 2022 11:40
@xon52 xon52 requested a review from zxch3n April 25, 2022 11:40
@zxch3n
Copy link
Member

zxch3n commented Apr 26, 2022

Previous changes broke debugging. I pushed a commit that fix the issue. Can you check whether debugging & running tests is working now on your machine?

@xon52
Copy link
Contributor Author

xon52 commented Apr 26, 2022

@zxch3n looks good and works fine for a normal run. Obviously debug still does not work on my machine but the primary function works well.
I made one small commit to make a string nicer but it should not affect anything I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants