Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cover in metadata on multiple discs. #34

Closed
ghost opened this issue Dec 15, 2020 · 6 comments
Closed

No cover in metadata on multiple discs. #34

ghost opened this issue Dec 15, 2020 · 6 comments

Comments

@ghost
Copy link

ghost commented Dec 15, 2020

When you try to download a release consisting of several discs the cover is not inserted in the metadata.

@vitiko98
Copy link
Owner

Post an example. And don't forget to enable the -e at the end of the command.

@ghost
Copy link
Author

ghost commented Dec 15, 2020

Post an example. And don't forget to enable the -e at the end of the command.

I noticed it while using VLC on android, I thought it was a problem due to the creation of the library; I just checked with "ffmpeg", all albums that are composed of multiple discs do not have the cover in the metadata and ofc I used "--embed-art" or "-e" via bash shell. The tool doesn't crash anyway during the downloads.

@vitiko98
Copy link
Owner

qobuz-dl should print a message like Error embedding image: <exception>. Please try to reproduce.

@ghost
Copy link
Author

ghost commented Dec 16, 2020

Nope, i don't get this message and I don't see anything strange through "gdb". Did you check yourself?
To be clear this is the missing "value" with "ffmpeg", for example:

    Stream #0:1: Video: mjpeg (Baseline), yuvj420p(pc, bt470bg/unknown/unknown), 1400x1400 [SAR 300:300 DAR 1:1], 90k tbr, 90k tbn, 90k tbc (attached pic)
    Metadata:
      comment         : Cover (front)
      title           : cover

@cattivik66
Copy link

Actually there isn't any cover stored in the file even if the album has only 1 CD.
In fact if you move the FLAC file to a new location without the cover.jpg file, and you open it with a player, the cover would not be displayed.

@vitiko98
Copy link
Owner

vitiko98 commented Dec 16, 2020

Actually there isn't any cover stored in the file even if the album has only 1 CD.
In fact if you move the FLAC file to a new location without the cover.jpg file, and you open it with a player, the cover would not be displayed.

You trippin' hard. I tried moving the file to another location and the cover art is still there:

2020-12-16-131314_305x76_scrot

Cover type                               : Cover (front)
Cover MIME                               : image/jpeg

Anyway, @zozzza was right about covers not showing with multiple discs. This issue is closed in dev branch for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants