Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it's too easy to accidentally use host paths in published thunk .jsons #96

Open
vito opened this issue Mar 16, 2022 · 1 comment
Open

Comments

@vito
Copy link
Owner

vito commented Mar 16, 2022

The v0.1.0 and v0.1.1 releases include .json files that only worked on my machine, because they accidentally embed host paths.

The fix for this is easy case-by-case but this feels like an easy footgun with passing host paths into thunks.

@vito vito added this to the v0.2.0 milestone Mar 16, 2022
@vito
Copy link
Owner Author

vito commented Mar 19, 2022

Being able to encode a host path to JSON is useful for communicating over a local network to an external runtime. (edit: key word being local, since the host paths have to still make sense.)

This might be the cue to introduce a different format for publishing which can be understood by bass -e. The format could dedupe repeated thunks like bass.lock does, and host paths could error when converting to this format.

@vito vito removed this from the v0.2.0 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant