Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handle scenes with 3D on both screens (Sora flashbacks) #71

Closed
vitor251093 opened this issue Mar 7, 2024 · 4 comments
Closed
Labels
double 3D scene Issue involving 3D appearing on both screens at the same time enhancement New feature or request
Milestone

Comments

@vitor251093
Copy link
Owner

Instead of showing both screens side by side, that kind of scene should be handled on a more proper manner.

More details in #23

@vitor251093 vitor251093 added enhancement New feature or request requires melonDS evolution Requires a feature in melonDS that wasn't introduced yet labels Mar 7, 2024
@vitor251093 vitor251093 added this to the v0.3.0 milestone Mar 7, 2024
@vitor251093 vitor251093 added the double 3D scene Issue involving 3D appearing on both screens at the same time label Mar 22, 2024
@vitor251093 vitor251093 modified the milestones: v0.3.0, v1.0.0 Mar 22, 2024
@JordanAClark
Copy link

Hey, sorry if this is in the wrong spot, I am not used to how github works. I just did mission 41 Eliminate the Morning Star. In this mission the game (as in intended behavior) only shows the 3D Sora flashback on the bottom screen for the first few seconds of the fight with the Morning Star. The problem is that after that happens in Melon Mix, it stays in the dual screen view for the rest of the battle, even though the bottom screen is just black. Ideally when the bottom screen goes black it should just revert to the top screen only view.

@vitor251093
Copy link
Owner Author

vitor251093 commented May 22, 2024

@JordanAClark yeah, this is part of what this issue intends to deal with.

It shows both screens because, despite the fact that the bottom screen is black, the 3D is still being rendered on the bottom screen; it's just the brightness that is disabled, per say. And scenes with 3D on both screens are still not properly supported.

Reverting to the top screen when the bottom one is black isn't that simple because of the way melonDS handles 3D on both screens in the OpenGL renderer.

@JordanAClark
Copy link

Ah ok. Thought I had a case outside what had been discussed, but sounds like it has been considered and is being worked on

@vitor251093 vitor251093 modified the milestones: v1.0.0, v0.4.0, v0.3.0 May 30, 2024
@vitor251093 vitor251093 removed the requires melonDS evolution Requires a feature in melonDS that wasn't introduced yet label Jun 1, 2024
@vitor251093 vitor251093 changed the title Proper handle scenes with 3D on both screens Proper handle scenes with 3D on both screens (Sora flashbacks) Jun 1, 2024
@vitor251093
Copy link
Owner Author

For now, that is issue is considered as solved starting from v0.3.0. If any issue is encountered is any specific scene, specific bugs will be created to handle them specifically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
double 3D scene Issue involving 3D appearing on both screens at the same time enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants