Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Direct replies have "reply" marker instead of "root" marker #629

Closed
AutumnSunshine opened this issue Oct 1, 2023 · 0 comments
Closed

Comments

@AutumnSunshine
Copy link
Contributor

Describe the bug
On Amethyst, direct replies to root have the "reply" marker instead of NIP-10 mandated "root" marker.
This disrupts the thread chain & sometimes the replies to this reply, show up as replies to the root note in the Notifications tab.
(This is a minor issue found only in Notifications view - when displayed in Conversations view, the ordering is perfect)

To Reproduce
Steps to reproduce the behavior:

  1. Select any Note A & reply to it on Amethyst (B). B will mention "A" with a "reply" marker & not "root" marker.
  2. Reply to B from another client (C) (I used Nostter.vercel.app) -- still no root marker in any note
  3. Reply to C from Amethyst (D). Now for some reason, this D note mentions B as "root"
  4. Reply to D from Amethyst/any other client (E). E will show up in notifications tab as a reply to B & not to D.

Expected behavior
Direct replies to root, to have "root" marker instead of "reply" marker in kind1
Amethyst allows replies on Public chat, streams, communities, etc & maybe there are other dependencies for this reply structure.
This is a very minor issue -- just wanted to bring to your notice (I've also informed Nostter dev)

Video and Screenshots

Sample Note IDs:
--Direct reply having "reply" marker:
https://nostr.band/note1d2kcxmw3t7695hfmx3avl0dpdna933clm7u5tgap8w9ul066gpjsv493kx
--Direct reply having "reply" marker, causing "root" to be marked incorrectly, as described earlier
B= https://nostr.band/note1nrxek00xxpkr8799t7pvnuka3c0z8sdc9cl6hy63s39tzn8u7xpqc52g78
D= https://nostr.band/note1773v5m6usr5jmsww8yhr4mkkhx9krdma5nur2lncjp856pzhgh6qu6897w

Device (please complete the following information):

  • Phone Brand/Model : NA
  • Android Version [e.g. 33]: NA
  • App Version : v0.76.0-Play

Bounty (in Bitcoin sats) offered for a solution

@AutumnSunshine AutumnSunshine changed the title Direct replies have "reply" marker instead of "root" marker [BUG] Direct replies have "reply" marker instead of "root" marker Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant