Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkImage keycodes are invalid #1

Open
sb8244 opened this issue Aug 9, 2021 · 1 comment
Open

checkImage keycodes are invalid #1

sb8244 opened this issue Aug 9, 2021 · 1 comment

Comments

@sb8244
Copy link

sb8244 commented Aug 9, 2021

The key property is loosely checked as 46, 8. I noticed on Chrome that the evt.key property comes back like "Backspace" or "Delete". I adjusted the function to get deletion working in my modified code:

if (
  (evt as KeyboardEvent).key === 'Backspace' ||
  (evt as KeyboardEvent).key === 'Delete'
)
@sb8244 sb8244 mentioned this issue Aug 9, 2021
@sb8244
Copy link
Author

sb8244 commented Aug 9, 2021

Also, big thanks for making this library TS compatible and for fixing the window dependencies. It seems to work well for me so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant