-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to skip ci run #213
Conversation
Add feature to ask user should ci run be skipped.
The beta extension of this pull has been built in the workflow! 🎉 |
@nenadfilipovic Cool PR! BTW.
|
Set promptCi as false by default to preserve current user experience.
Ok I have changed it to be false by default. To answer other 2 questions:
|
@yi-Xu-0100 Any more questions? |
👋 @nenadfilipovic, thanks for your great contribution! ❤ I think it is a clear way to prompt the condition about the skip CI. After reviewing the realization about the prompt, I have a little advice about the format of the prompt. @vivaxy May we can make the prompt to have choices with two options? The first one is For the above optional skip CI prompt, maybe it should prompt after choose the emoji. |
The beta extension of this pull has been built in the workflow! 🎉 |
Use quick select prompt instead of input box.
Set promptCi as false by default to preserve current user experience.
Ok, latest changes:
|
Format markdown table inside readme with http://markdowntable.com/.
Update promptCi documentation that reflects that prompt is disabled by default.
The beta extension of this pull has been built in the workflow! 🎉 |
@vivaxy @yi-Xu-0100 do you think PR is good? |
@vivaxy, I think a little discussion is needed here about my reviews. 🧐 I had made a beta extension for the current pr to be used temporarily if you require it- #213 (comment). 😁@nenadfilipovic |
Look Good To Me. A trivial discussion:
Second thought, why is that? |
@vivaxy I think the selection can be simply completed by a mouse so that it should be prompt after emoji, and after that, it all will be keyboard things (even we can use By the way, what is your opinion about the configuration variable naming and translation I suggested above? |
I may misunderstand the GitHub UI review works, I have make reviews two days ago, but I did not successfully submit my review, I thought you all saw it. Sorry for the late work. 😅 |
I can't say anything about Chinese translation because I don't speak it. We can also use promptSkipCI no problem about that. |
Thanks @yi-Xu-0100 . It's a thoughtfully review. |
@vivaxy I have pushed the changes to this PR. If there is no other problem, I will squash and merge this PR and publish it next Friday. 🧐 @nenadfilipovic Thanks for your great PR! ❤ |
The beta extension of this pull has been built in the workflow! 🎉 |
Good job, very nice experience working with you @vivaxy @yi-Xu-0100 👋 |
PR summary:
Fix: #212
@vivaxy please check if chinese translation is correct I have used google translate