Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add new scope selection #51

Merged
merged 3 commits into from
Mar 2, 2021
Merged

feat: ✨ add new scope selection #51

merged 3 commits into from
Mar 2, 2021

Conversation

yi-Xu-0100
Copy link
Collaborator

Add new scope and only use for the current time.
This scope will not be added in workspace seting.json

Close #50

Add new scope and only use for the current time.
This scope will not be added in workspace `seting.json`

Close #50
@yi-Xu-0100
Copy link
Collaborator Author

@vivaxy I appreciate it if there are any reviews here. 😀

@vivaxy
Copy link
Owner

vivaxy commented Mar 1, 2021

@yi-Xu-0100 Sorry for the delay. I am busy these days. Do you like to become an official collaborator to the extension?

@yi-Xu-0100
Copy link
Collaborator Author

@vivaxy I feel very honored that you have invited me to be a collaborator, and I am also happy to be a member of the maintainer. But I am not very good at developing extensions. When I become a collaborator, I will try my best to learn how to maintain it. 😀

I tested the extension of this feature in VS Code by running a debugging task, but I just added it based on your code. If there are any errors, I will fix them as soon as possible. 😊

@yi-Xu-0100
Copy link
Collaborator Author

@vivaxy I have a litter of confusion about the publishing workflow of VS Code extensions. Whether it already has action about the publishing at the same time when making a tag or not?

Copy link
Owner

@vivaxy vivaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thank you for your contribution. I hope we can work together to make the extension better.

Here are some quick reviews. They are only my concerns and are not necessarily problems.

  1. The new functionality should not break the current user experience. At least not adding more burden to the users.
  2. Little concern about the language pack mentioned in the code review.

package.nls.json Outdated Show resolved Hide resolved
@vivaxy
Copy link
Owner

vivaxy commented Mar 1, 2021

@yi-Xu-0100 About publishing the extension. Currently it runs only on my computer with yarn release command. It does such things.

  1. Bump a proper version. Write the version in package.json, CHANGELOG.md, and git tag.
  2. Update the CHANGELOG.md with detailed changes.
  3. Compile ts code to js code.
  4. Run vsce publish.
  5. Push new git tag to remote.

Maybe we can:

  1. Document the standard operating procedures.
  2. Try to make it automatic, i.e Github Actions.

I'd like to add you as an extension member on Microsoft VSCode extension marketplace. Please email me the email address of your account on https://marketplace.visualstudio.com/.

@yi-Xu-0100
Copy link
Collaborator Author

@vivaxy I have emailed my personal information to your contact email on your GitHub profile. I am very happy to be one of the collaborators. ❤

For the publishing workflow, I am familiar with the GitHub action and try to achieve it in the future. 😀

use `use` instead of `create`
@yi-Xu-0100 yi-Xu-0100 merged commit 05a5b39 into vivaxy:master Mar 2, 2021
@yi-Xu-0100 yi-Xu-0100 deleted the use-scope-without-adding-configuration branch March 2, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] use manually scope for commit
2 participants