-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ add new scope selection #51
feat: ✨ add new scope selection #51
Conversation
Add new scope and only use for the current time. This scope will not be added in workspace `seting.json` Close #50
@vivaxy I appreciate it if there are any reviews here. 😀 |
@yi-Xu-0100 Sorry for the delay. I am busy these days. Do you like to become an official collaborator to the extension? |
@vivaxy I feel very honored that you have invited me to be a collaborator, and I am also happy to be a member of the maintainer. But I am not very good at developing extensions. When I become a collaborator, I will try my best to learn how to maintain it. 😀 I tested the extension of this feature in VS Code by running a debugging task, but I just added it based on your code. If there are any errors, I will fix them as soon as possible. 😊 |
@vivaxy I have a litter of confusion about the publishing workflow of VS Code extensions. Whether it already has action about the publishing at the same time when making a tag or not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome and thank you for your contribution. I hope we can work together to make the extension better.
Here are some quick reviews. They are only my concerns and are not necessarily problems.
- The new functionality should not break the current user experience. At least not adding more burden to the users.
- Little concern about the language pack mentioned in the code review.
@yi-Xu-0100 About publishing the extension. Currently it runs only on my computer with
Maybe we can:
I'd like to add you as an extension member on Microsoft VSCode extension marketplace. Please email me the email address of your account on https://marketplace.visualstudio.com/. |
@vivaxy I have emailed my personal information to your contact email on your GitHub profile. I am very happy to be one of the collaborators. ❤ For the publishing workflow, I am familiar with the GitHub action and try to achieve it in the future. 😀 |
use `use` instead of `create`
Add new scope and only use for the current time.
This scope will not be added in workspace
seting.json
Close #50