Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

Fix username issue when loading image and button to open github user profile #140

Merged
merged 1 commit into from Oct 17, 2022

Conversation

safwanidrees
Copy link
Contributor

@safwanidrees safwanidrees commented Oct 16, 2022

1- Fix the username issue when loading the image and
2- The button to open the GitHub user profile directly from the detail page.
3- User images also showed on the detail page with animation.
4- Safe Area problem in the both screens
5- Other Fixes

@viveeeeeek
Copy link
Owner

Please also try to upload screenshot or working video sample with your PR description

@viveeeeeek viveeeeeek closed this Oct 17, 2022
@viveeeeeek viveeeeeek reopened this Oct 17, 2022
@safwanidrees
Copy link
Contributor Author

PR.Demo.mp4

Previously image was not loading for all users because the name conversion to username was wrong so I fixed that. I also fixed the SafeArea problem on both pages plus now the GitHub profile is directly open as well with a username. In description page I am also showing user picture with animation

@viveeeeeek
Copy link
Owner

Awesome work buddy! keep contributing and wish you happy Hacktoberfest!

@viveeeeeek
Copy link
Owner

@safwanidrees can you please check in the code. user image is not being showed.

@safwanidrees
Copy link
Contributor Author

In Web Image Not Loading I fixed that.

image

Although, Some user images will not show because we did not have the user's actual GitHub username we are converting their name to a username. So suppose the user's actual name is Safwan Mamji but its GitHub username is safwanidrees so if we convert its name Safwa Mamji to username it will be safwanmamji. So the image will not load due to the wrong username.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants