Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

Added dark mode #84

Merged
merged 4 commits into from Oct 15, 2021
Merged

Added dark mode #84

merged 4 commits into from Oct 15, 2021

Conversation

AwsmAsim
Copy link
Contributor

@AwsmAsim AwsmAsim commented Oct 15, 2021

For Hacktoberfest 2021
Added icon at the top right corner and added dark mode (GIF Attached).
Changes done in:

  • pubspec,yaml (added provider and shared_preferences)
  • homepage.screens.dart
  • added controller
    1stHacktoberfest - Google Chrome 2021-10-15 20-51-53

@viveeeeeek
Copy link
Owner

Great work @AwsmAsim buddy!
Thank you for contributing.

@viveeeeeek
Copy link
Owner

Even if we switch to dark theme it is only applicable for homepage only.
Can you please implement it for detailed screen too?
let me know I'll create new issue for it.

Thank you.

@viveeeeeek viveeeeeek merged commit c32c1c6 into viveeeeeek:master Oct 15, 2021
@AwsmAsim
Copy link
Contributor Author

Yeah, we can do that with the text. But since we are using a background image, there we have to use the Consumer every time.
Shall we implement this with the text color ?

@viveeeeeek
Copy link
Owner

not with the text but on detail page
image
here

@AwsmAsim
Copy link
Contributor Author

Yeah we can

@AwsmAsim
Copy link
Contributor Author

Already implemented, please create an issue so that I could raise a PR.

@viveeeeeek
Copy link
Owner

Yup! Check #86 👍🏼

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants