Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Use static-ffmpeg to remove ffmpeg dependency #199

Open
zackees opened this issue Apr 26, 2024 · 7 comments
Open

Feature Request: Use static-ffmpeg to remove ffmpeg dependency #199

zackees opened this issue Apr 26, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@zackees
Copy link

zackees commented Apr 26, 2024

Hi there, I am the author of static-ffmpeg. I humbly request you use this library (ffmpeg v5) so that you can skip the ffmpeg install step.

https://github.com/zackees/static_ffmpeg

@vivekuppal vivekuppal added the enhancement New feature or request label Apr 27, 2024
@vivekuppal
Copy link
Owner

Thank you for the suggestion. It will help the end users simplify the installation of transcribe. static_ffmpeg seems like a good way forward.
Are there any other implications I should be aware of for this change.

@zackees
Copy link
Author

zackees commented May 1, 2024

You can use static_ffmpeg.add_paths() to make ffmpeg work everywhere and in subprocesses.

@vivekuppal
Copy link
Owner

Thanks.
Seems like static_ffmpeg is currently using ffmpeg v5. Installing ffmpeg installs ffmpeg v7. Are there plans to upgrade to latest version of ffmpeg.

@zackees
Copy link
Author

zackees commented May 1, 2024

Yeah, at 7.1 but it will be called static-ffmpeg7

@vivekuppal
Copy link
Owner

That sounds great.
Please link a PR or issue or other relevant links related to static-ffmpeg7 so we can follow the developments on that front.

@vivekuppal
Copy link
Owner

Draft PR with the minimal required changes #200
Once we are at latest ffmpeg version, we can complete the PR.

@vivekuppal
Copy link
Owner

@zackees ping for static-ffmpeg7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants