-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Drag and drop #24
Comments
Hi Paul! Cool that you are using vivict! I am not one of the maintainers, but I could probably give it a go. I noticed that the implementation you linked to was using the Apache license, while this project is using MIT as per the [https://github.com/vivictorg/vivict/blob/a539c6201b3b747aa6b9f25cc0c04bdbbebe27b7/CONTRIBUTING.md](contributing guidelines). I am by far not an expert on open source licenses, but what I can gather from [https://joinup.ec.europa.eu/licence/compatibility-check/Apache-2.0/MIT](this compatibility check), I think it would be ok to re-license it as MIT in this project, but wanted to check with you first. And with the maintainers of vivict too, of course. |
Regarding the implementation - I am thinking it would be best to have the drop targets on each half of the screen regardless of where the split in the video is currently. Mostly since the target for one of the sides might be very small at times otherwise. What do you think? |
I also think drag and drop sounds like a nice addition. I don't have much time to work on vivict these days sadly, but if @mflodin would implement this I would be very happy and would try to help if needed. |
I don't believe there's any concern from a licensing perspective, but the implementation we're talking about here is pretty standard, so... whatever!
YUP. I was thinking the exact same thing. :) |
Great! Just wanted to make sure I wouldn't get vivict into any trouble.
Perfect! |
I'd absolutely love to just drag 'n drop the two assets into the browser. Would be super convenient for me.
I don't have the time to contribute this feature right now, but I've done DND a few times. I'd probably lift this implementation.
Thanks for vivict! It's been hugely valuable for me.
The text was updated successfully, but these errors were encountered: