Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerhub repo #2

Closed
klauspost opened this issue Jul 30, 2019 · 11 comments
Closed

Add dockerhub repo #2

klauspost opened this issue Jul 30, 2019 · 11 comments

Comments

@klauspost
Copy link
Contributor

Add to dockerhub.

It should be possible to set up so tags are automatically updated.

@zvymazal
Copy link
Member

zvymazal commented Nov 7, 2019

Docker repository vivino/rankdb has been created and connected with GitHub. New releases should automatically be built and published.

@klauspost
Copy link
Contributor Author

@zvymazal Should we release a new version to test it?

@zvymazal
Copy link
Member

zvymazal commented Nov 7, 2019

Yes 👍

@klauspost
Copy link
Contributor Author

Will do. I have a dependency update as well.

@klauspost
Copy link
Contributor Author

We might as well include #4 as well, but maybe with Go 1.13?

@klauspost
Copy link
Contributor Author

I had to add another GITHUB_TOKEN to travis, since releases are seen as branches and it was only available to master.

Anyway releases are working, but not so sure about dockerhub. Shouldn't there be something here: https://hub.docker.com/r/vivino/rankdb

@zvymazal
Copy link
Member

zvymazal commented Nov 7, 2019

There was some configuration missing. I'm testing it now.

@zvymazal
Copy link
Member

zvymazal commented Nov 7, 2019

The Docker image builds are breaking on these two:

COPY api/conf/conf.stub.toml /conf/conf.toml -> COPY conf/conf.stub.toml /conf/conf.toml
COPY deploy/docker-entrypoint.sh /usr/bin/ -> ?

@klauspost
Copy link
Contributor Author

Still have the file. Lemme update.

@zvymazal
Copy link
Member

zvymazal commented Nov 7, 2019

@zvymazal
Copy link
Member

zvymazal commented Nov 7, 2019

The rules are configured to build master and release tags 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants