Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support section-end mark (line with only hashes) #175

Merged
merged 1 commit into from
Oct 13, 2023
Merged

feat: Support section-end mark (line with only hashes) #175

merged 1 commit into from
Oct 13, 2023

Conversation

MurakamiShinyu
Copy link
Member

@MurakamiShinyu MurakamiShinyu commented Oct 12, 2023 •
edited
Loading

This adds the following rule on sectionization:

  • A line with only #s can be used to end the section whose depth matches the number of the #s.
    • e.g., the section starting with ### Heading 3 can end with ###.

(related to #155, thanks @nosuke23 for the suggestion)

Base automatically changed from fix/issue171 to main October 12, 2023 22:48
@MurakamiShinyu
feat: Support section-end mark (line with only hashes)
4bbf3a7 
This adds the following rule on sectionization:

- A line with only `#`s can be used to end the section whose depth matches the number of the `#`s.
  - e.g., the section starting with `### Heading 3` can end with `###`.

(related to #155, thanks @nosuke23 for the suggestion)
@MurakamiShinyu MurakamiShinyu marked this pull request as ready for review October 13, 2023 05:31
akabekobeko
akabekobeko approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@akabekobeko akabekobeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
対応ありがとうございました！

@akabekobeko akabekobeko merged commit 63869ed into main Oct 13, 2023
3 checks passed
@akabekobeko akabekobeko deleted the feat/section-end-mark branch October 13, 2023 09:59
@akabekobeko akabekobeko self-assigned this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akabekobeko akabekobeko akabekobeko approved these changes

Assignees

@akabekobeko akabekobeko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MurakamiShinyu @akabekobeko