Dockerfile fails to copy vivo home

[ghost]

Describe the bug

=> ERROR [4/6] COPY ./installer/home/target/vivo /vivo-home                                                                    0.0s

To Reproduce

Follow https://github.com/vivo-project/VIVO#docker-compose

Expected behavior

Should build images and run VIVO.

Screenshots

Environment (please complete the following information):

• OS: Windows
• Browser: N/A
• Tomcat version: N/A
• VIVO version: master
• Apache Solr or ElasticSearch version: N/A

Additional context

[gneissone]

@wwelling Does this fix the issue? 1dd3b40

The change is already in 1.12.1-maint.

[ghost]

It does but will break on next version change.

[ghost]

Also, I checked 1.12.1-maint Dockerfile and it does not have that change but the pom does have that change.

[ghost]

https://github.com/vivo-project/VIVO/blob/rel-1.12.1-maint/Dockerfile#L13
https://github.com/vivo-project/VIVO/blob/rel-1.12.1-maint/installer/home/pom.xml#L28

[ghost]

#3644

[gneissone]

The commit history on that PR is confusing. The relevant change is re-adding <finalName>${app-name}</finalName> to installer/home/pom.xml, the change to the Dockerfile was added then removed. That pom tag results in the target home directory being named vivo instead of vivo-installer-home-x.x.x

[ghost]

This works from rel-1.12.1-maint branch. Closing. Shouldn't the default branch in GitHub being the development branch? I sense some disarray still.