Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new object property button shouldn't be available if neither of 'select from existing' nor 'provide selection' options set #3858

Open
litvinovg opened this issue Apr 17, 2023 · 2 comments · Fixed by vivo-project/Vitro#385
Open

Add new object property button shouldn't be available if neither of 'select from existing' nor 'provide selection' options set #3858

litvinovg opened this issue Apr 17, 2023 · 2 comments · Fixed by vivo-project/Vitro#385
Assignees
@litvinovg

Comments

@litvinovg
Copy link
Collaborator

Describe the bug
Add new object property button shouldn't be available if neither of 'select from existing' nor 'provide selection' options set

To Reproduce
Steps to reproduce the behavior:

  1. Log in
  2. Create an object property, don't select 'select from existing' nor 'provide selection' options.
  3. Open individual page where the object property is listed
  4. Add button is going to be available
    image
  5. If you click on it error will appear because
    image

Expected behavior
Add button shouldn't be available in case neither of options described above is set.
@litvinovg litvinovg added the Low label Apr 17, 2023
@litvinovg
Copy link
Collaborator Author

Edit button should also be hidden if neither of 'select from existing' nor 'provide selection' options set

@chenejac chenejac added rc and removed Low rc labels Apr 19, 2023
@litvinovg litvinovg self-assigned this Apr 24, 2023
@litvinovg litvinovg mentioned this issue Apr 24, 2023
Merged
@chenejac chenejac linked a pull request Apr 27, 2023 that will close this issue
don't create add url if neither of 'select from existing' nor 'provid… vivo-project/Vitro#385
Merged
@chenejac chenejac mentioned this issue May 18, 2023
Open
@chenejac
Copy link
Contributor

The linked PR has been reverted - vivo-project/Vitro#389

@chenejac chenejac reopened this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@litvinovg litvinovg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't create add url if neither of 'select from existing' nor 'provid… litvinovg/Vitro
2 participants
@chenejac @litvinovg