Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Poetry with pyproject.toml #228

Closed
2 of 4 tasks
veghdev opened this issue Mar 28, 2023 · 2 comments · Fixed by #249
Closed
2 of 4 tasks

use Poetry with pyproject.toml #228

veghdev opened this issue Mar 28, 2023 · 2 comments · Fixed by #249
Assignees
Labels
good first issue Good for newcomers

Comments

@veghdev
Copy link
Member

veghdev commented Mar 28, 2023

Instead of setup.py create a pyproject.toml file.

@jharibo
Copy link

jharibo commented Mar 30, 2023

Hi! I would be really keen to pick up the rest of the tasks in this ticket for my first contribution, if they aren't assigned to anyone already. Just to check my understanding is correct, is the proposal here to move dependency management away from requirements.txt to Poetry and improve the experience for developers on Macs by using poe and Poetry?

I'd be happy to work on the corresponding tickets in ipyvizzu-story too - namely vizzuhq/ipyvizzu-story#44 and vizzuhq/ipyvizzu-story#60.

@veghdev
Copy link
Member Author

veghdev commented Mar 31, 2023

Hi @jharibo!
Thank you for your help.

We would like to use poetry with pyproject.toml, instead of setup.py. But we will switch only after all related tasks are completed.
So in ipyvizzu there is a draft-pyproject.toml file, and it will be good to make a similar in ipyvizzu-story.

The first task is in the draft file, fugue is under 'dependencies ', but its only an extra.

The other part is more complex, we would like to get rid of the makefile, and use a task runner which fits better in a python environment and it would also be good, if it only depends on python and not on os. #197 #229
Now, we compile dev dependecies with pip-compile, I think this should also be changed if we want to support multiple python versions and os.

If you start working with a specific part-task, please comment under the related issue :) and we can separate the task list into more sub-tasks in the descriptions.

Feel free to submit a separate PR for each subtask you're working on. Thanks.

@schaumb schaumb removed the enhancement New feature or request label Jul 3, 2023
@veghdev veghdev changed the title python development: use Poetry with pyproject.toml use Poetry with pyproject.toml Jul 3, 2023
@veghdev veghdev self-assigned this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants