-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Object ID's against a Customer license #5
Comments
While I agree that this might make sense, typically this should be found during testing as you should either tun your automated or at least manual tests against the customers license before delivery to customer |
I agree (partially), you can receive a notification or error when something's wrong with the object range depending on you customers license. It's just a waste of time and resources being informed afterwards. |
You are absolutely correct, it would be nice to have it caught earlier and we are also still debating different solutions on how to do this the best way for any customer specific additions we are adding (we are trying to avoid them like the plague, but can't always). I am basically saying that I don't know, if this extension is the right way of solving the issue, especially when you want to support different scenarios. For instance, I can see this working (e.g. with using the detailed report that you can download) and have it parse against it. This could be done in here, but it could also be another service or module that you can use to test locally, but also run it through the pipeline so that you can test in different ways. If you have it in here, then this would have to be exposed from the backend to your pipeline so that you can test it as well during your build (so that it only tests the app and not the test app, which would then be run during the test pipeline). |
Just to chip in, this is an interesting suggestion. I'm keeping it open, and I'll handle it at some point (I have some other more urgent things). Pull requests are always welcome, also 😉 |
Completed in v2.5.0. Check the release notes here: https://github.com/vjekob/al-objid/blob/master/vscode-extension/docs/ReleaseNotes.v2.5.0.md |
@vjekob , |
Hi @vjekob ,
First of all thank you for this cool VSCode extension.
I just imagined that it could be useful that there should be a warning if an new object is not in the customers license.
Sometimes this problem only arises when the new feature request is already in the test-environment of the customer and creates an awkward situation where the customer is informed to buy ore objects while testing it's new feature.
Regards,
Job
The text was updated successfully, but these errors were encountered: