Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommission "extras" #170

Closed
cashaffer opened this issue Sep 7, 2014 · 3 comments
Closed

Decommission "extras" #170

cashaffer opened this issue Sep 7, 2014 · 3 comments

Comments

@cashaffer
Copy link
Collaborator

Based on our email discussions, the following needs to happen to eliminate the "extras" directory.

  • sound support should be moved somewhere else within JSAV.
  • "stack" support should be moved somewhere else within JSAV (perhaps rename?)
  • AVL, redblacktree, and binaryheap support will be moved to a new directory within OpenDSA.
@vkaravir
Copy link
Owner

vkaravir commented Sep 9, 2014

My goal was to move things to more suitable places, not to eliminate the extras directory. So I think sound can stay where it is, it is an extension (or an extra) to JSAV.

I also meant for the "stack" support to be moved to the new directory within OpenDSA. What do you think?

@cashaffer
Copy link
Collaborator Author

My goal was to move things to more suitable places, not to eliminate the extras directory.
So I think sound can stay where it is, it is an extension (or an extra) to JSAV.

Does this comment refer to "sound.js"? Where ever you think best.
As for "stack", I don't believe that that belongs in the new DataStructures directory at OpenDSA. It is definitely not a data structure layout extension. It is a control widget, most typically (so far) used to support exercises. To me it makes sense to leave it in JSAV. It is sort of like the slideshow controls widget or the exercise score widget.

@vkaravir
Copy link
Owner

All the AVs now seem to be using AVL tree, redblacktree, and binaryheap from the OpenDSA repository, so I'll remove them from JSAV repo and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants