fix(unmarshal): handle $type: Array with non-arrays

boosterfuels · Mar 17, 2017 · f65c063 · f65c063
1 parent 4ca9487
commit f65c063
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/src/unmarshal/index.js b/src/unmarshal/index.js
@@ -80,13 +80,6 @@ function visitArray(arr, schema, projection, path) {
   let error = new ValidateError();
   let curPath = realPathToSchemaPath(path);
   let newPath = join(curPath, '$');
-  if (!schema._paths[newPath] || !schema._paths[newPath].$type) {
-    debug('skipping', newPath);
-    return {
-      value: arr,
-      error: null
-    };
-  }
 
   if (arr == null) {
     return {
@@ -99,6 +92,14 @@ function visitArray(arr, schema, projection, path) {
     arr = [arr];
   }
 
+  if (!schema._paths[newPath] || !schema._paths[newPath].$type) {
+    debug('skipping', newPath);
+    return {
+      value: arr,
+      error: null
+    };
+  }
+
   debug('newPath', newPath, schema._paths[newPath].$type);
   arr.forEach(function(value, index) {
     if (schema._paths[newPath].$type === Array ||

diff --git a/test/unit.test.js b/test/unit.test.js
@@ -190,6 +190,15 @@ describe('unmarshal()', function() {
     });
   });
 
+  it('boolean to array', function() {
+    let Band = new Archetype({
+      test: { $type: Array }
+    }).compile();
+
+    const res = new Band({ test: true });
+    assert.deepEqual(res.test, [true]);
+  });
+
   it('casts deeply nested arrays', function() {
     const Graph = new Archetype({
       points: [[{ $type: 'number' }]]