Better test coverage for execPost

index.js

@@ -97,7 +97,6 @@ Kareem.prototype.execPost = function(name, context, args, callback) {
   var posts = this._posts[name] || [];
   var numPosts = posts.length;
   var currentPost = 0;
-  var done = false;
 
   if (!numPosts) {
     return process.nextTick(function() {
@@ -111,9 +110,6 @@ Kareem.prototype.execPost = function(name, context, args, callback) {
     if (post.length > args.length) {
       post.apply(context, args.concat(function(error) {
         if (error) {
-          if (done) {
-            return;
-          }
           return callback(error);
         }
 

test/examples.test.js

@@ -151,6 +151,33 @@ describe('post hooks', function() {
       done();
     });
   });
+
+  it('can use synchronous post hooks', function(done) {
+    var execed = {};
+
+    hooks.post('cook', function(eggs, bacon) {
+      execed.first = true;
+      assert.equal(1, eggs);
+      assert.equal(2, bacon);
+    });
+
+    hooks.post('cook', function(eggs, bacon, callback) {
+      execed.second = true;
+      assert.equal(1, eggs);
+      assert.equal(2, bacon);
+      callback();
+    });
+
+    hooks.execPost('cook', null, [1, 2], function(error, eggs, bacon) {
+      assert.ifError(error);
+      assert.equal(2, Object.keys(execed).length);
+      assert.ok(execed.first);
+      assert.ok(execed.second);
+      assert.equal(1, eggs);
+      assert.equal(2, bacon);
+      done();
+    });
+  });
 });
 
 describe('wrap()', function() {

test/post.test.js

@@ -0,0 +1,46 @@
+var assert = require('assert');
+var Kareem = require('../');
+
+describe('execPost', function() {
+  var hooks;
+
+  beforeEach(function() {
+    hooks = new Kareem();
+  });
+
+  it('handles errors', function(done) {
+    hooks.post('cook', function(eggs, callback) {
+      callback('error!');
+    });
+
+    hooks.execPost('cook', null, [4], function(error, eggs) {
+      assert.equal('error!', error);
+      assert.ok(!eggs);
+      done();
+    });
+  });
+
+  it('multiple posts', function(done) {
+    hooks.post('cook', function(eggs, callback) {
+      setTimeout(
+        function() {
+          callback();
+        },
+        5);
+    });
+
+    hooks.post('cook', function(eggs, callback) {
+      setTimeout(
+        function() {
+          callback();
+        },
+        5);
+    });
+
+    hooks.execPost('cook', null, [4], function(error, eggs) {
+      assert.ifError(error);
+      assert.equal(4, eggs);
+      done();
+    });
+  });
+});

test/pre.test.js

@@ -39,23 +39,25 @@ describe('execPre', function() {
     var execed = {};
 
     hooks.pre('cook', true, function(next, done) {
-      next();
       execed.first = true;
       setTimeout(
         function() {
           done('error!');
         },
         5);
+
+      next();
     });
 
     hooks.pre('cook', true, function(next, done) {
-      next();
       execed.second = true;
       setTimeout(
         function() {
           done('other error!');
         },
         10);
+
+      next();
     });
 
     hooks.execPre('cook', null, function(err) {
@@ -72,12 +74,13 @@ describe('execPre', function() {
 
     hooks.pre('cook', true, function(next, done) {
       execed.first = true;
-      next();
       setTimeout(
         function() {
           done('other error!');
         },
         15);
+
+      next();
     });
 
     hooks.pre('cook', true, function(next, done) {
@@ -104,12 +107,13 @@ describe('execPre', function() {
 
     hooks.pre('cook', true, function(next, done) {
       execed.first = true;
-      next();
       setTimeout(
         function() {
           done('other error!');
         },
         5);
+
+      next();
     });
 
     hooks.pre('cook', true, function(next, done) {
@@ -119,7 +123,7 @@ describe('execPre', function() {
           next('error!');
           done('another error!');
         },
-        15);
+        25);
     });
 
     hooks.execPre('cook', null, function(err) {
@@ -136,12 +140,13 @@ describe('execPre', function() {
 
     hooks.pre('cook', true, function(next, done) {
       execed.first = true;
-      next();
       setTimeout(
         function() {
           done('other error!');
         },
         5);
+
+      next();
     });
 
     hooks.pre('cook', function(next) {
@@ -167,12 +172,13 @@ describe('execPre', function() {
 
     hooks.pre('cook', true, function(next, done) {
       execed.first = true;
-      next();
       setTimeout(
         function() {
           done();
         },
         5);
+
+      next();
     });
 
     hooks.pre('cook', function() {