Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justify Text feature does not work in Build preview. #228

Closed
johnblommers opened this issue May 25, 2020 · 3 comments
Closed

Justify Text feature does not work in Build preview. #228

johnblommers opened this issue May 25, 2020 · 3 comments
Assignees
Labels
bug Issue: Something isn't working

Comments

@johnblommers
Copy link

johnblommers commented May 25, 2020

In novelWriter v0.6:

If the user has selected Menu→Tools→Preferences→Layout→Justify the text margins in editor and viewer→✗ and then proceeds to Build the novel, the Justify text selection only left justifies regardless of its setting.

If the user has selected Menu→Tools→Preferences→Layout→Justify the text margins in editor and viewer→✓ and then proceeds to Build the novel, the Justify text selection works properly.

@vkbo
Copy link
Owner

vkbo commented May 25, 2020

The editor and viewer text preferences do not transfer to the build preview. The build novel project tool has its own formatting preferences. Since the editor is actually plain text, no formatting is applied to the text itself by these settings. The build tool, however, does apply formatting.

@vkbo vkbo self-assigned this May 25, 2020
@vkbo vkbo added documentation Request: Changes to documentation not a bug Invalid: Feature, not a bug labels May 25, 2020
@vkbo
Copy link
Owner

vkbo commented May 25, 2020

Wait, now I get it. It was a bit difficult to parse the meaning here. That is indeed a bug. The export should work just fine, but the preview window actually does use the settings from Preferences. I copy/pasted some of the code from the regular viewer panel, and forgot to replace the settings value.

Will fix!

@vkbo vkbo added bug Issue: Something isn't working and removed not a bug Invalid: Feature, not a bug documentation Request: Changes to documentation labels May 25, 2020
@vkbo vkbo mentioned this issue May 25, 2020
@vkbo
Copy link
Owner

vkbo commented May 25, 2020

Fixed in PR #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants