Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

Do not raise unhandled exception on unknown --output_type #40

Merged
merged 1 commit into from Nov 12, 2019
Merged

Do not raise unhandled exception on unknown --output_type #40

merged 1 commit into from Nov 12, 2019

Conversation

osyvokon
Copy link
Contributor

yttm encode was failing like this on invalid --output_type:

...
  File "/home/silver/miniconda3/lib/python3.6/site-packages/youtokentome/yttm_cli.py", line 104, in encode
    % output_type
TypeError: %d format: a number is required, not str

This could be fixed by fixing a format string from %d to %s, but a better option is to let Click handle args validation.

@yutkin
Copy link
Contributor

yutkin commented Nov 12, 2019

Could you apply Black formatting for your PR, please?

xbelonogov
xbelonogov previously approved these changes Nov 12, 2019
View reviewed changes
@yutkin yutkin added the enhancement New feature or request label Nov 12, 2019
@yutkin yutkin self-requested a review November 12, 2019 09:45
@osyvokon
Copy link
Contributor Author

@yutkin, done!

@yutkin yutkin merged commit 32fae61 into VKCOM:master Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yutkin yutkin yutkin approved these changes

@xbelonogov xbelonogov Awaiting requested review from xbelonogov

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@osyvokon @yutkin @xbelonogov