Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.springframework.social.vkontakte.api.VKontakteProfile does not have fields for Instagram and livejournal user names #42

Closed
dan-s1 opened this issue Aug 5, 2015 · 9 comments

Comments

@dan-s1
Copy link

dan-s1 commented Aug 5, 2015

Per the Vk documentation (http://vk.com/dev/fields_2) for the connections field there are multiple values possible skype, facebook, twitter, livejournal, instagram. I noticed between the org.springframework.social.vkontakte.api.VKontakteProfile and the org.springframework.social.vkontakte.api.impl.json.VKontakteProfileMixin there are placeholders for
skype, facebook, facebookName and twitter. Can these classes be modified to allow for storing the instagram and livejournal user names? Thanks!

@dan-s1
Copy link
Author

dan-s1 commented Aug 21, 2015

I noticed in commit 850aef3 an instagram property was added to
org.springframework.social.vkontakte.api.VKontakteProfile.java and to
org.springframework.social.vkontakte.api.impl.json.VKontakteProfileMixin.java. The problem I noticed is in the resulting JSON there is no instagram field as there is no JsonProperty annotation over the instagram property in org.springframework.social.vkontakte.api.impl.json.VKontakteProfileMixin.java as there is with the other properties (@JsonProperty("instagram") )

@dan-s1
Copy link
Author

dan-s1 commented Aug 21, 2015

Sorry 850aef3 is the parent and specifically commit 1385114

@disovi
Copy link
Contributor

disovi commented Aug 22, 2015

There is no need to annotate fields wich names are identical to json names. Instagram field should work properly, you can check the test https://github.com/vkolodrevskiy/spring-social-vkontakte/blob/master/spring-social-vkontakte/src/test/java/org/springframework/social/vkontakte/api/impl/UsersTemplateTest.java

@dan-s1
Copy link
Author

dan-s1 commented Aug 27, 2015

I noticed that is was working for other users but I had a case in point where a user had multiple connections, instagram being one of them and it was not showing up.
Also I am curious if there is no need to annotate fields whose names are identical to json names, then why are domain, online, twitter, skype, facebook, site, status, graduation, relation, interests, music, activities, movies, tv, books, games, about and quotes all annotated?

@disovi
Copy link
Contributor

disovi commented Aug 27, 2015

Can you give ids of those users? We can remove those annotations, this is just legacy)

@dan-s1
Copy link
Author

dan-s1 commented Aug 28, 2015

I am sorry I tried the user again and I am noticing the instagram entry. I am not sure what made me think it wasn't there.

@dan-s1
Copy link
Author

dan-s1 commented Aug 28, 2015

But somewhat related is for user with 7019889 I notice on his page he has connections for Skype, Instagram, Twitter, Facebook and LiveJournal yet the API when I curl from the command line
curl "https://api.vk.com/method/users.get?v=5.27&user_ids=7019889&fields=connections" it returns all of these connections except for Skype. Would you know why this is the case?

@disovi
Copy link
Contributor

disovi commented Aug 28, 2015

It looks like a vk bug.

@vkolodrevskiy
Copy link
Owner

Since library depends on VK API SDK closing this. Refer to SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants