Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use editorconfig_core constant for comparison #2

Merged
merged 1 commit into from
Oct 30, 2018
Merged

use editorconfig_core constant for comparison #2

merged 1 commit into from
Oct 30, 2018

Conversation

ninewise
Copy link
Contributor

@ninewise ninewise commented Oct 8, 2018

String comparison didn't seem to work for me (editorconfig_core 0.2.0).

ericmathison
ericmathison approved these changes Oct 29, 2018
View reviewed changes
Copy link

@ericmathison ericmathison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@silversquirl silversquirl merged commit 524af71 into seifferth:master Oct 30, 2018
@7v0lk0v 7v0lk0v mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmathison ericmathison ericmathison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ninewise @ericmathison @silversquirl