Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onPanResponderTerminationRequest cancels day selector swipes too easily #18

Open
bijoutrouvaille opened this issue Aug 4, 2017 · 1 comment · May be fixed by #27
Open

onPanResponderTerminationRequest cancels day selector swipes too easily #18

bijoutrouvaille opened this issue Aug 4, 2017 · 1 comment · May be fixed by #27

Comments

@bijoutrouvaille
Copy link

Related to #1 , the pan responder is very janky inside scrollview containers. If the swiping gesture for day selector moves up or down even just a little, enough to activate the scrollview, the day selector swipe cancels. The swiper has to have a very steady hand, therefore.

I found the following line in DaySelector.react.js

onPanResponderTerminationRequest: (evt, gestureState) => true,

and changed true to false

onPanResponderTerminationRequest: (evt, gestureState) => false,

and it seems to have done the trick. Do you see potential problems with this change, or can we have that change implemented in the source?
@bijoutrouvaille
Copy link
Author

thanks for the awesome component too, not to forget :)

This was referenced Jan 30, 2018
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bijoutrouvaille