Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync gym-dolphin? #18

Open
wenkesj opened this issue Nov 26, 2017 · 2 comments
Open

Sync gym-dolphin? #18

wenkesj opened this issue Nov 26, 2017 · 2 comments

Comments

@wenkesj
Copy link

wenkesj commented Nov 26, 2017

Do you plan on syncing this repository with gym-dolphin or vice-versa? I noticed that you don't necessarily support gym as the standard environment for phillip. I really appreciate all the contributions that this repository has made to the community, especially the possibility of extending this to support MARL environments with gym-dolphin that follow ssbm.

Really awesome stuff, Vlad!

@vladfi1
Copy link
Owner

vladfi1 commented Nov 26, 2017

The main reason phillip doesn't use gym is because it doesn't support multi-agent environments (or at least didn't when I created gym-dolphin).

@wenkesj
Copy link
Author

wenkesj commented Nov 27, 2017

@vladfi1 thanks for the response. I guess I'm misunderstanding. I believe as a gym environment there can be "multi-agent" environments for MARL without a problem (reference is just an example with different tools). If you are sampling the state at a set frequency, all agents have the option to step the environment synchronously (or asynchronously depending on the way your implementation sees it). I've been looking at the current gym-dolphin implementation, and it seems like it is possible, but may require some work on my end. The reason I'm mentioning this is because I am interested in MARL, and the framework you've built around dolphin is the most high performing I have seen and would hate to see it's potential with gym slowly fade away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants