Skip to content

Commit

Permalink
Use version 0.29.1 (#87)
Browse files Browse the repository at this point in the history
* Update dependencies

* Use version 0.29.1
  • Loading branch information
vladikoff committed May 15, 2021
1 parent b81ca89 commit c30af35
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Use `GECKODRIVER_SKIP_DOWNLOAD` to skip the download of the geckodriver file.
## Versions

* [npm module version] - [geckodriver version]
* 2.00.x - geckodriver 0.29.1, support changed to node v12+
* 1.22.x - geckodriver 0.29.0
* 1.21.x - geckodriver 0.28.0
* 1.20.x - geckodriver 0.27.0
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if (skipDownload === 'true') {
var baseCDNURL = process.env.GECKODRIVER_CDNURL || process.env.npm_config_geckodriver_cdnurl || 'https://github.com/mozilla/geckodriver/releases/download';
var CACHED_ARCHIVE = process.env.GECKODRIVER_FILEPATH ? path.resolve(process.env.GECKODRIVER_FILEPATH) : undefined;

var version = process.env.GECKODRIVER_VERSION || process.env.npm_config_geckodriver_version || '0.29.0';
var version = process.env.GECKODRIVER_VERSION || process.env.npm_config_geckodriver_version || '0.29.1';

// Remove trailing slash if included
baseCDNURL = baseCDNURL.replace(/\/+$/, '');
Expand Down
2 changes: 1 addition & 1 deletion lib/geckodriver.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ process.env.PATH += path.delimiter + path.join(__dirname, '..');
exports.path = process.platform === 'win32' ? path.join(__dirname, '..', 'geckodriver.exe') : path.join(__dirname, '..', 'geckodriver');

// specify the version of geckodriver
exports.version = process.env.GECKODRIVER_VERSION || '0.29.0';
exports.version = process.env.GECKODRIVER_VERSION || '0.29.1';

exports.start = function(args) {
exports.defaultInstance = require('child_process').execFile(exports.path, args);
Expand Down
2 changes: 1 addition & 1 deletion test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ test.cb('properly extracts', t => {

test('programmatic usage', t => {
var driver = require('../lib/geckodriver')
t.is(driver.version, '0.29.0')
t.is(driver.version, '0.29.1')
});

0 comments on commit c30af35

Please sign in to comment.