Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing French Canadian Address with Occupancy #8

Open
phicote opened this issue Nov 12, 2019 · 3 comments
Open

Parsing French Canadian Address with Occupancy #8

phicote opened this issue Nov 12, 2019 · 3 comments

Comments

@phicote
Copy link

phicote commented Nov 12, 2019

Hello Vlad! Congratulations for this amazing work, I really appreciate. However, I noticed that the parser has problems with some cases of French Canadian addresses.

Examples
This address doesn't parse at all

  • 2545, rue De Lorimier, bureau 100, Longueuil, QC, J4K3P7

This one parse but the result is wrong, occupancy is set to None and city is set to bureau 100 Longueuil

  • 2545, rue De Lorimier, bureau 100 Longueuil, QC, J4K3P7
    {'full_address': '2545, rue De Lorimier, bureau 100 Longueuil, QC, J4K3P7, Canada', 'full_street': '2545, rue De Lorimier', 'street_number': '2545', 'street_type': 'rue', 'street_name': 'De Lorimier', 'route_id': None, 'post_direction': None, 'floor': None, 'building_id': None, 'occupancy': None, 'postal_box': None, 'city': 'bureau 100 Longueuil', 'region1': 'QC', 'postal_code': 'J4K3P7', 'country_id': 'CA'}

Here are some other examples of addresses that do not parse, but seem valid to me, probably because they contain hyphens, parenthesis or something else:

  • 110-395 Rue des Érables, Salaberry-de-Valleyfield, QC, J6T6T5, Canada
  • 1095 Rue de la Visitation, Saint-Charles-Borromée, QC, J6E0W7, Canada
  • 461 Rue Dufferin, Salaberry-de-Valleyfield, QC, J6S2B3, Canada
  • 200-1345 Boul Dagenais Ouest (Sainte-Rose), Laval, QC, H7L5Z9, Canada
  • 3149 Boul Dagenais Ouest (Fabreville), Laval, QC, H7P1T8, Canada
  • 655 Rue Boucher, Saint-Jean-sur-Richelieu, QC, J3B8P4, Canada
  • 101-2575 32e Avenue (LaSalle), Montréal, QC, H8T3G9, Canada
  • 3875 Boul Sainte-Rose (Laval-Ouest), Laval, QC, H7R1V2, Canada
  • 1840 32e Avenue (Lachine), Montréal, QC, H8T3M6, Canada
  • 123 Rue Huot, Notre-Dame-de-l'Île-Perrot, QC, J7V7M4, Canada
  • 1468 Boul Monseigneur-Langlois, Salaberry-de-Valleyfield, QC, J6S1C2, Canada
  • 93 Ave Conrad-Gosselin, Saint-Jean-sur-Richelieu, QC, J2X0A1, Canada
  • 795 Ave de Grande-Île, Salaberry-de-Valleyfield, QC, J6S3N9, Canada
  • 525 Rue Gadbois, Saint-Jean-sur-Richelieu, QC, J3A1V1, Canada
  • 400 Rue Croisetière, Saint-Jean-sur-Richelieu, QC, J2X0E5, Canada
  • 695 DU PONT, Terrebonne, QC, J6W1A2, Canada
  • 5150 Boul Dagenais Ouest (Laval-Ouest), Laval, QC, H7R1L8, Canada
  • 1250 Boul Dagenais Ouest (Fabreville), Laval, QC, H7L5E3, Canada
  • 1889 Boul Dagenais Ouest (Sainte-Rose), Laval, QC, H7L5A3, Canada
  • 149 MTEE DU MOULIN, Laval, QC, H7N3Y8, Canada
  • 3675 Boul Dagenais Ouest (Fabreville), Laval, QC, H7P5C9, Canada
  • 398 Boul Curé-Labelle (Chomedey), Laval, QC, H7V2S3, Canada
  • 3251 Boul Dagenais Ouest (Fabreville), Laval, QC, H7P1V3, Canada
  • 196 Rue St-Louis, Saint-Jean-sur-Richelieu, QC, J3B1Y1, Canada
  • 2525B Rue du Pont, Marieville, QC, J3M0C5, Canada
  • 1585 du Chevrotin, Richelieu, QC, J3L4Y3, Canada
  • 91 Ave Conrad-Gosselin, Saint-Jean-sur-Richelieu, QC, J2X0A1, Canada
  • 1000 Boul du Séminaire N, Saint-Jean-sur-Richelieu, QC, J3A1E5, Canada
  • A-1645A Aut Jean-Noël-Lavoie, Laval, QC, H7L3W3, Canada

Could you please take a look? My knowledge of regular expressions is very limited

@ezzaimsoufiane
Copy link

@phicote im currently facing the same problem, have you found any solution to this?

@phicote
Copy link
Author

phicote commented May 5, 2021

@phicote im currently facing the same problem, have you found any solution to this?

Hello @ezzaimsoufiane, I haven't found a solution, but my knowledge of regular expressions has improved since that time and I might try to take a look. On the other hand, I do not offer any guarantee of success.

@ezzaimsoufiane
Copy link

Hello @ezzaimsoufiane, I haven't found a solution, but my knowledge of regular expressions has improved since that time and I might try to take a look. On the other hand, I do not offer any guarantee of success.

@phicote would very much appreciate it, i'm trying to addapt this to adresses from France.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants