Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank window? #23

Closed
mhingston opened this issue Apr 22, 2018 · 5 comments
Closed

Blank window? #23

mhingston opened this issue Apr 22, 2018 · 5 comments

Comments

@mhingston
Copy link

Thanks for the repo, I've tried using the 0.3.1 and 0.3.2 AppImages but I'm just getting a blank window with the dev tools on the right when launching the app.

Linux 4.16.3-1-ARCH #1 SMP PREEMPT

image

@vladimiry
Copy link
Owner

@mhingston thanks for the report, just tried to run both versions, work well for me.

It looks like you are running app with NODE_ENV=development environment variable set. That would explain the described behavior. Can you make sure it's not like that? Such env variable enables the dev mode running app in which you get the dev console opened and main app page set to http://localhost:3000/index.html (served by webpack-dev-server) instead of the local page.

Alternately you can try the most recent version protonmail-desktop-app-0.4.0-linux-x86_64.AppImage prepared from master, which has got the NODE_ENV renamed to NODE_ENV_RUNTIME plus some minor changes.

By the way, do other linux package formats work well for you?

@mhingston
Copy link
Author

Thanks @vladimiry, I was able to get it working using the 0.4.0 AppImage. I will give the other Linux packages a try and get back to you.

@vladimiry
Copy link
Owner

vladimiry commented Apr 23, 2018

I think if you just make sure that there is no NODE_ENV=development environment variable set, then 0.3.1 and 0.3.2 will also work well. With this variable other linux packages most likely will face the same issue, as code is the same. 0.4.0 works because NODE_ENV got renamed to NODE_ENV_RUNTIME. @mhingston can you please confirm that it works when there is no NODE_ENV=development set, so I could close the issue.

I'm going to release 0.4.0 with electron v2 rc (it's in beta state), or maybe earlier if there will be a specific need.

@mhingston
Copy link
Author

mhingston commented Apr 23, 2018

Yep, I tested 0.3.1 and 0.3.2 with NODE_ENV unset but as I need to have that env var set on my system for other software I'm building/debugging so I chose to upgrade to 0.4.0. Thanks again.

@vladimiry
Copy link
Owner

@mhingston, runtime env variables usage got improved with new v0.4.3 release (about to be published). It's now only two and prefixed: PROTONMAIL_DESKTOP_APP__USER_DATA_DIR and PROTONMAIL_DESKTOP_APP__E2E, see constants. Changing main html page app-built-in/local vs http://localhost:3000/index.html doesn't happen in runtime anymore for production builds, customization is happening on build stage. Which means there will be chance to get shown blank page again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants