Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary node file with random name - issue 5 regression #41

Closed
ask2018 opened this issue Aug 2, 2018 · 7 comments
Closed

temporary node file with random name - issue 5 regression #41

ask2018 opened this issue Aug 2, 2018 · 7 comments

Comments

@ask2018
Copy link

ask2018 commented Aug 2, 2018

Since version 1.2.0 there is back this problem - #5
Up to version 1.1.1 everything is ok.

@vladimiry
Copy link
Owner

The solution for #5 was in unpacking native dependencies, so Electron doesn't unpack them every time with a random file name. It might be that new native dependencies got added which I didn't care to unpack yet, will look into it.

Meanwhile, it would be helpful to get more details. Like OS name and version used, temporary files location, exact files size in bytes or md5 hash of those files (so I could know for sure which native dependency it's related to).

@ask2018
Copy link
Author

ask2018 commented Aug 2, 2018

OS is the same as for issue 5 - Win 7 64bit with all security updates
Versions from 1.2.0 to 1.4.0
temporary files location - same as for issue 5 - "C:\Users\USERNAME\AppData\Local\Temp\some_random_string.tmp.node"
File size for version 1.4.0 - some_random_string.tmp.node - 522752 bytes
MD5 for version 1.4.0 - some_random_string.tmp.node - a68852ad89aa2b1f7c2c7b3e0b402fbc

@vladimiry
Copy link
Owner

That file is a leveldown related native dependency, add as a part of the local store WIP feature.

Here is the version with fix applyed - email-securely-app-1.4.1-windows-nsis-installer.exe, will be included into the next release. Please confirm it solves the issue.

@ask2018
Copy link
Author

ask2018 commented Aug 2, 2018

Unfortunately still the same problem with version 1.4.1 you posted. File size and MD5 are also still the same for node file.

@vladimiry
Copy link
Owner

Did some changes and made sure that this version doesn't create 522752 bytes sized temp file anymore (leveldown binary), running Win 10.

I noticed though that app creates a png icon file with a randomly generated name in the same temp folder, let me know if that's a deal breaker.

@ask2018
Copy link
Author

ask2018 commented Aug 2, 2018

Now it works fine. Thank you. PNG file I've also noticed before, but that should not be problem for me.

@vladimiry
Copy link
Owner

Ok, closing then as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants