Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

. #67

Closed
ohkeepa opened this issue Nov 14, 2018 · 9 comments
Closed

. #67

ohkeepa opened this issue Nov 14, 2018 · 9 comments
Labels

Comments

@ohkeepa
Copy link

ohkeepa commented Nov 14, 2018

.

@vladimiry
Copy link
Owner

Do the respective context menu actions work?

@vladimiry
Copy link
Owner

@ohkeepa can you try a build from this folder? Copy/pasting using hotkeys works if I run macOS under a virtual machine, but it might be not the same as running on a real device. Also asking @joshirio to try it.

@joshirio
Copy link
Contributor

Copying with CMD+C works when viewing an email but not when composing (writing) one.

It works if you use the context menu though. Maybe if the context menu actions in the composing window get CMD+C/V assigned it might work.

@vladimiry
Copy link
Owner

Maybe if the context menu actions in the composing window get CMD+C/V assigned it might work.

According to the documentation to make hotkeys work on macOS I will need to add respective actions to the main app menu, not to the context menu, so it would be a sort of app global hotkeys. I didn't want to extend the main app menu and tried to go with a workaround which as we can see doesn't work fully properly.

So going to extend the main app menu for macOS only. It still might not be working due to opened Electron bugs (like this and this), but we better try it in our own.

@joshirio
Copy link
Contributor

Yeah, never programmed with electron only with Qt so that was just a guess. I think as long as the context menus work it's usable, thanks

@vladimiry
Copy link
Owner

It's usable, but I'd like to close known bugs before releasing the final v2 version.

@vladimiry
Copy link
Owner

@joshirio can you try updated build in the same Dropbox folder. There are two different implementations, role and custom subfolders, hope at least one of them is working well.

@vladimiry vladimiry added the bug label Nov 20, 2018
@vladimiry
Copy link
Owner

vladimiry commented Nov 20, 2018

So the issue remains open, have no more ideas for now.

@vladimiry
Copy link
Owner

Copying with CMD+C works when viewing an email but not when composing (writing) one.

I looked deeper into the copy/pasting not working while composing issue and seem to found out why it didn't work. It's because message editing is happening inside a dynamically created iframe element. So now I'm processing the dynamically created iframes too and so hopefully all the cases will be properly handled with a new version uploaded here. Can someone try it? I promise there will be no more new builds for today 😊

@ohkeepa ohkeepa changed the title Mac CMD+C and CMD+V do not allow Copy/Paste in emails . Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants