Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Better style button icons on "From Text" page #1377

Closed
afbagwell opened this issue Jun 9, 2023 · 18 comments
Closed

[Feature]: Better style button icons on "From Text" page #1377

afbagwell opened this issue Jun 9, 2023 · 18 comments
Labels
enhancement New feature or request ui UI related item

Comments

@afbagwell
Copy link

Feature description

I know these have gone through a few iterations, but so far this is the worst of them. The current icons are completely indecipherable. Even after using them heavily, I'm only remembering what they do based on position -- and sometimes I even screw that up.

Right now from left to right, here's my initial impression:

  • book (?)
  • man doing something
  • Internet
  • luggage (? - honestly no idea)
  • lock safe (?)

Can they be replaced by something from the Bootstrap library or another UI icon library with a cleaner look and more obvious meanings? They also need a hover text on them to describe their function.

Version Platform Description

4a3ab4e

@afbagwell afbagwell added the enhancement New feature or request label Jun 9, 2023
@vladmandic
Copy link
Owner

icons are not even icons, right now they are limited to whats available as unicode characters.
new ui will have actual icons when its released. in the meantime, i don't plan to spend time tweaking unicode characters.

@vladmandic vladmandic added ui UI related item and removed enhancement New feature or request labels Jun 9, 2023
@afbagwell
Copy link
Author

Good to know! Thanks!

@brknsoul
Copy link
Contributor

brknsoul commented Jun 9, 2023

i don't plan to spend time tweaking unicode characters

I'm just wondering why they were changed in the first place. ;-)

@mariodian
Copy link

mariodian commented Jun 11, 2023

At least title="description" for each button would be nice (I can make a PR) so that you get an info on mouse over.

@vladmandic
Copy link
Owner

@mariodian hints were disabled due to error in parsing for couple of days, they are back on as of yesterday.

@mariodian
Copy link

Got it! Although, I don't see those because I'm using the kitchen-theme :(

@vladmandic
Copy link
Owner

@mariodian you should see new hints that i've published yesterday regardless of the theme. if you don't, that's pretty bad.

@mariodian
Copy link

I see it in the code in browser console but don't see it on the page itself. Also I do see hint related stuff in console.log:

Screenshot 2023-06-13 at 8 22 54 PM

@vladmandic
Copy link
Owner

375 hints were correctly set and type 2 means that it should show as box in the top right corner on the screen which appears on mouse over.

@mariodian
Copy link

It can't be visible because .tooltip-show doesn't rewrite display: none defined in .tooltip:

.tooltip {
    display: none;
}
.tooltip-show {
    opacity: 1;
}

Since it's hidden with display: none, it needs to be displayed with display: block (or you can hide it with opacity: 0 instead)

@mariodian
Copy link

After a bit of investigating, canvas-zoom plugin for whatever reason sets display: none for .tooltip which messes with your code.

@vladmandic
Copy link
Owner

amazing...why? :(

@mariodian
Copy link

They do have their own tooltip but its class is .tooltip--extension anyway so perhaps it's an old code that they don't use anymore?

Screenshot 2023-06-13 at 9 46 24 PM

Do you want me to open an issue with them or would you do it?

@vladmandic
Copy link
Owner

you can do it - why not?

@mariodian
Copy link

The issue is fixed now!

@afbagwell
Copy link
Author

I'm running into an issue with the tooltip box being invisible and blocking clicking whatever button it's hovering over. Attached some pictures to show. This has been aggravating because I often am not completely scrolled to the top of my browser, and I click the generate button and when my attention comes back I realize nothing happened.

tooltip01
tooltip02
tooltip03

@vladmandic
Copy link
Owner

You can change tooltip display mode in settings.

@vladmandic vladmandic added the enhancement New feature or request label Jul 9, 2023
@vladmandic
Copy link
Owner

further work is tracked under ui redesign, individual improvements in this area are not expected otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui UI related item
Projects
None yet
Development

No branches or pull requests

4 participants