[Issue]: --skip-git fails installation

[mirh]

Issue Description

I guess this isn't liked.

automatic/installer.py

Lines 680 to 684 in 82973c4

	log.info('Verifying packages')
	clip_package = os.environ.get('CLIP_PACKAGE', "git+https://github.com/openai/CLIP.git")
	install(clip_package, 'clip')
	invisiblewatermark_package = os.environ.get('INVISIBLEWATERMARK_PACKAGE', "git+https://github.com/patrickvonplaten/invisible-watermark.git@remove_onnxruntime_depedency")
	install(invisiblewatermark_package, 'invisible-watermark')

Installation technically fails complaining about missing k-diffusion and typing_extensions folders, but presumably that's only a consequence.

Version Platform Description

Latest git, W10, python 3.11.

Relevant log output

INFO     Installing package: typing-extensions==4.9.0
INFO     Verifying packages
INFO     Installing package: git+https://github.com/openai/CLIP.git
ERROR    Error running pip: install --upgrade git+https://github.com/openai/CLIP.git
INFO     Installing package:
                         git+https://github.com/patrickvonplaten/invisible-watermark.git@remove_onnxruntime_depedency
ERROR    Error running pip: install --upgrade
                         git+https://github.com/patrickvonplaten/invisible-watermark.git@remove_onnxruntime_depedency
INFO     Installing package: pi-heif

(both commands fail when they cannot find git.exe)

[vladmandic]

i'm not sure i understand - if you use --skip-git, it doesn't remove the fact that those repos are needed for proper install?

[mirh]

Du-uh, then what's the argument even for? Maybe it should be called skip updates.
Given I just figured that even when git is available, the installation still fails

┌───────────────────────────────────────── Traceback (most recent call last) ─────────────────────────────────────────┐
│ A:\automatic\launch.py:263 in <module>                                                                              │
│                                                                                                                     │
│   262 if __name__ == "__main__":                                                                                    │
│ > 263     main()                                                                                                    │
│   264                                                                                                               │
│                                                                                                                     │
│ A:\automatic\launch.py:240 in main                                                                                  │
│                                                                                                                     │
│   239                                                                                                               │
│ > 240     uv, instance = start_server(immediate=True, server=None)                                                  │
│   241     while True:                                                                                               │
│                                                                                                                     │
│ A:\automatic\launch.py:168 in start_server                                                                          │
│                                                                                                                     │
│   167     get_custom_args()                                                                                         │
│ > 168     module_spec.loader.exec_module(server)                                                                    │
│   169     uvicorn = None                                                                                            │
│ in exec_module:940                                                                                                  │
│ in _call_with_frames_removed:241                                                                                    │
│                                                                                                                     │
│ A:\automatic\webui.py:11 in <module>                                                                                │
│                                                                                                                     │
│    10 from threading import Thread                                                                                  │
│ >  11 import modules.loader                                                                                         │
│    12 import torch # pylint: disable=wrong-import-order                                                             │
│                                                                                                                     │
│ A:\automatic\modules\loader.py:48 in <module>                                                                       │
│                                                                                                                     │
│   47                                                                                                                │
│ > 48 from fastapi import FastAPI # pylint: disable=W0611,C0411                                                      │
│   49 import gradio # pylint: disable=W0611,C0411                                                                    │
│                                                                                                                     │
│ A:\automatic\venv\Lib\site-packages\fastapi\__init__.py:7 in <module>                                               │
│                                                                                                                     │
│    6                                                                                                                │
│ >  7 from .applications import FastAPI as FastAPI                                                                   │
│    8 from .background import BackgroundTasks as BackgroundTasks                                                     │
│                                                                                                                     │
│ A:\automatic\venv\Lib\site-packages\fastapi\applications.py:16 in <module>                                          │
│                                                                                                                     │
│     15                                                                                                              │
│ >   16 from fastapi import routing                                                                                  │
│     17 from fastapi.datastructures import Default, DefaultPlaceholder                                               │
│                                                                                                                     │
│ A:\automatic\venv\Lib\site-packages\fastapi\routing.py:22 in <module>                                               │
│                                                                                                                     │
│     21                                                                                                              │
│ >   22 from fastapi import params                                                                                   │
│     23 from fastapi._compat import (                                                                                │
│                                                                                                                     │
│ A:\automatic\venv\Lib\site-packages\fastapi\params.py:5 in <module>                                                 │
│                                                                                                                     │
│     4                                                                                                               │
│ >   5 from fastapi.openapi.models import Example                                                                    │
│     6 from pydantic.fields import FieldInfo                                                                         │
│                                                                                                                     │
│ A:\automatic\venv\Lib\site-packages\fastapi\openapi\models.py:4 in <module>                                         │
│                                                                                                                     │
│     3                                                                                                               │
│ >   4 from fastapi._compat import (                                                                                 │
│     5     PYDANTIC_V2,                                                                                              │
│                                                                                                                     │
│ A:\automatic\venv\Lib\site-packages\fastapi\_compat.py:20 in <module>                                               │
│                                                                                                                     │
│    19                                                                                                               │
│ >  20 from fastapi.exceptions import RequestErrorModel                                                              │
│    21 from fastapi.types import IncEx, ModelNameMap, UnionType                                                      │
│                                                                                                                     │
│ A:\automatic\venv\Lib\site-packages\fastapi\exceptions.py:6 in <module>                                             │
│                                                                                                                     │
│     5 from starlette.exceptions import WebSocketException as StarletteWebSocketException                            │
│ >   6 from typing_extensions import Annotated, Doc                                                                  │
│     7                                                                                                               │
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
ImportError: cannot import name 'Doc' from 'typing_extensions' (A:\automatic\venv\Lib\site-packages\typing_extensions.py)

[vladmandic]

skip-git is NOT intended for initial installs - additional logs do not change that.
skip-git is intended to allow usage on systems that do not have online connectivity to github by creating a full copy of some already fully installed copy of sdnext.

[mirh]

Indeed, then it should probably be renamed to avoid misunderstandings.

[vladmandic]

I'll make some changes in flag description.