Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to angular 2.0.0 #82

Closed
wants to merge 1 commit into from
Closed

Update to angular 2.0.0 #82

wants to merge 1 commit into from

Conversation

frankadrian
Copy link
Contributor

Let me know if you also want to upgrade Typescript to version 2 as in angular/quickstart@d3a977e

@nimaen
Copy link
Contributor

nimaen commented Sep 16, 2016

Thank you for your PR, can you please keep only one commit ?
Since you're updating to angular 2, there's no need to keep a rc7 commit 😉

@frankadrian
Copy link
Contributor Author

Sure, just squashed the commits!

@nimaen
Copy link
Contributor

nimaen commented Sep 16, 2016

Thanks !
I'll test it between 12pm and 2pm.

@nimaen nimaen self-assigned this Sep 16, 2016
@nimaen
Copy link
Contributor

nimaen commented Sep 16, 2016

Have you tried a simple npm start ?
I've got some zone issues with your branch.

@frankadrian
Copy link
Contributor Author

Sorry, only saw your comment now! I'm going to have a look at this now!

@frankadrian
Copy link
Contributor Author

Hmm, it is working for me! I also removed the node_modules and typings directory, ran npm install just to be sure. Can you try these steps and report if the problem still exists?

@nimaen
Copy link
Contributor

nimaen commented Sep 20, 2016

Still no chance, I'll have another attempt tonight :)

@pumano
Copy link

pumano commented Sep 24, 2016

any news about 2.0 support?

@nimaen
Copy link
Contributor

nimaen commented Sep 25, 2016

Ok, I've been tricked by the demo folder.
Your PR is good, but the demo is not working since the static demo zone.js file is not updated.
I've created an issue to only use node_modules files, not static files.
Please add the new zone.js file in the demo/vendor path for the time being.
Otherwise, GJ 👍

@vladotesanovic : this is really problematic, we should really check #80.

@nimaen
Copy link
Contributor

nimaen commented Sep 27, 2016

Done in 7a0857f

@nimaen nimaen closed this Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants