This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
REF: py38, sphinx>=1.7.0, try/except add_config_value("author") #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westurner
changed the title
…d_config_value("author")
closes vladris#112
closes vladris#117
westurner
force-pushed
the
sphinx3_support
branch
from
ac0cc40
to
534b987
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 3.2.1 already defines a config value named author, so this patch just
passes when anExtensionErroris raised when trying toadd_config_value("author").The tests pass with tox (upgraded to py38) and local output appears to be unchanged from building before this patch.
closes #112
closes #117
There's a new nonfatal error which may be resolved by a fix for #114 (~Allow passthrough configuration from conf.py)
Is that a regression, or can this be merged?