Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait Support #4

Open
tantaman opened this issue Feb 21, 2021 · 1 comment
Open

Trait Support #4

tantaman opened this issue Feb 21, 2021 · 1 comment

Comments

@tantaman
Copy link
Collaborator

No description provided.

@tantaman
Copy link
Collaborator Author

This is the case where multiple nodes should share a common interface and the schema maintainer would like to create an edge to that interface rather than the concrete nodes.

An alternative implementation would be to do this as union types rather than traits or interfaces.

E.g.,

Foo as Node {
} & OutboundEdges {
  things: Edge<Bar.fooId | Baz.fooId | Woo.fooId>
}

One problem is how to model that underlying query. If all three types are completely disjoint, what filters do we give the user to use?

Even if they are not disjoint, how do we generate the query type?

Do we inspect each type, collect together common properties, expose those as where methods?

And for the SQL storage -- do we only select fields that are compatible with a union operator?
And once we get the return we re-query based on ID to fully hydrate each node?

^-- all said problems exist in the trait world too except that we don't have to walk types during code generation.

An option in the trait world is to return only the data that fulfills the trait.. This will create hella problems for caching and row level privacy, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant