Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection pool support #46

Closed
tantaman opened this issue Aug 18, 2022 · 3 comments
Closed

Add connection pool support #46

tantaman opened this issue Aug 18, 2022 · 3 comments

Comments

@tantaman
Copy link
Collaborator

wa-sqlite serializes reads that are on the same connection.

We should update the sqlite connectors to:

  • have a single write connection (all writes are always serialized even at the sqlite level)
  • have N read connections

To allow for parallel reads.

@tantaman
Copy link
Collaborator Author

@tantaman
Copy link
Collaborator Author

49c6743

@tantaman
Copy link
Collaborator Author

tantaman commented Aug 26, 2022

Connection pooling isn't supported against in-memory db for node-sqlite3.

wa-sqlite still serializes queries even when multiple connections exist to the db. Maybe this can be resolved by opening a new worker per wa-sqlite connection.

We'll table connection pooling until perf becomes a larger issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant